phpunit6 enable failOnRisky

[phil-davis]

Description

In phpunit enable failOnRisky so we know about tests that phpunit thinks are "a bit odd"

Related Issue

• while looking into phpunit on PHP 7.2 or 7.3 can exit with 0 status when there are test fails #34858 we bumped PHPUnit to v6, and this is a flow-on setting

Motivation and Context

We did this already in apps. Be consistent and do it in core.

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[phil-davis]

Backport stable10 #34977

[codecov]

Codecov Report

Merging #34976 into master will decrease coverage by 0.8%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #34976      +/-   ##
============================================
- Coverage     65.37%   64.56%   -0.81%     
  Complexity    18587    18587              
============================================
  Files          1213     1213              
  Lines         70378    70344      -34     
  Branches       1295     1295              
============================================
- Hits          46007    45419     -588     
- Misses        23997    24551     +554     
  Partials        374      374

Flag	Coverage Δ	Complexity Δ
#javascript	52.85% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.92% <ø> (-0.9%)	18587 <ø> (ø)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/DB/PostgreSqlMigrator.php	0% <0%> (-100%)	6% <0%> (ø)
lib/private/DB/SQLiteSessionInit.php	0% <0%> (-100%)	4% <0%> (ø)
lib/private/DB/SQLiteMigrator.php	0% <0%> (-100%)	7% <0%> (ø)
...ilder/ExpressionBuilder/PgSqlExpressionBuilder.php	0% <0%> (-88.89%)	3% <0%> (ø)
lib/private/DB/AdapterOCI8.php	0% <0%> (-86.67%)	4% <0%> (ø)
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php	0% <0%> (-86.67%)	8% <0%> (ø)
lib/private/DB/AdapterPgSql.php	0% <0%> (-85.72%)	2% <0%> (ø)
lib/private/Repair/SqliteAutoincrement.php	0% <0%> (-85.19%)	9% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php	0% <0%> (-85.19%)	18% <0%> (ø)
lib/private/DB/AdapterSqlite.php	0% <0%> (-83.34%)	7% <0%> (ø)
... and 38 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 544cbef...aeb8601. Read the comment docs.

[codecov]

Codecov Report

Merging #34976 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #34976      +/-   ##
============================================
+ Coverage     65.37%   65.37%   +<.01%     
- Complexity    18587    18588       +1     
============================================
  Files          1213     1213              
  Lines         70378    70380       +2     
  Branches       1295     1295              
============================================
+ Hits          46007    46009       +2     
  Misses        23997    23997              
  Partials        374      374

Flag	Coverage Δ	Complexity Δ
#javascript	52.85% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.82% <ø> (ø)	18588 <ø> (+1)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
apps/files_sharing/templates/public.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
core/js/sharedialoglinkshareview.js	83.46% <0%> (ø)	0% <0%> (ø)	⬇️
...es_sharing/lib/Controller/Share20OcsController.php	85.84% <0%> (+0.02%)	203% <0%> (+1%)	⬆️
.../files_sharing/lib/Controllers/ShareController.php	54.58% <0%> (+0.2%)	54% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 544cbef...aeb8601. Read the comment docs.