Skip to content

[stable10] phpunit6 enable failOnRisky#34977

Merged
phil-davis merged 3 commits into
stable10from
stable10-phpunit6-enable-failOnRisky
Apr 6, 2019
Merged

[stable10] phpunit6 enable failOnRisky#34977
phil-davis merged 3 commits into
stable10from
stable10-phpunit6-enable-failOnRisky

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Backport #34976

@phil-davis phil-davis self-assigned this Apr 5, 2019
@phil-davis phil-davis mentioned this pull request Apr 5, 2019
11 tasks
@codecov

codecov Bot commented Apr 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34977 into stable10 will decrease coverage by 19.28%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable10   #34977       +/-   ##
===============================================
- Coverage       64.25%   44.97%   -19.29%     
===============================================
  Files            1281      116     -1165     
  Lines           76670    11565    -65105     
  Branches         1307     1307               
===============================================
- Hits            49265     5201    -44064     
+ Misses          27024     5983    -21041     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 30.71% <ø> (-34.75%) 0 <ø> (-19994)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4992d9...7feb029. Read the comment docs.

@codecov

codecov Bot commented Apr 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #34977 into stable10 will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34977      +/-   ##
==============================================
+ Coverage       64.25%   64.27%   +0.01%     
+ Complexity      19994    19993       -1     
==============================================
  Files            1281     1281              
  Lines           76670    76648      -22     
  Branches         1307     1307              
==============================================
- Hits            49265    49263       -2     
+ Misses          27024    27004      -20     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.47% <ø> (+0.01%) 19993 <ø> (-1) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
lib/private/Share20/DefaultShareProvider.php 98.37% <0%> (-0.06%) 120% <0%> (-1%)
apps/encryption/lib/Crypto/EncryptAll.php 93.36% <0%> (+9.95%) 46% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4992d9...d4d870d. Read the comment docs.

@phil-davis phil-davis marked this pull request as ready for review April 5, 2019 15:51
@phil-davis phil-davis merged commit 294ecdb into stable10 Apr 6, 2019
@delete-merged-branch delete-merged-branch Bot deleted the stable10-phpunit6-enable-failOnRisky branch April 6, 2019 05:55
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants