Get job id only if sauce environment variables are set#35007
Merged
Conversation
The `getWebDriverSession` is not part of the `Mink\Driver\DriverInterface`, but is provided by the `Selenium2Driver`. So, as Sauce uses selenium grid, this will only be used when Sauce environment variables are set (other drivers do not have this).
Contributor
Author
|
When researching this, I found But, our |
Codecov Report
@@ Coverage Diff @@
## master #35007 +/- ##
============================================
+ Coverage 65.37% 65.37% +<.01%
Complexity 18622 18622
============================================
Files 1215 1215
Lines 70510 70510
Branches 1295 1295
============================================
+ Hits 46095 46096 +1
+ Misses 24041 24040 -1
Partials 374 374
Continue to review full report at Codecov.
|
phil-davis
approved these changes
Apr 12, 2019
Contributor
|
Backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getWebDriverSessionis not part of theMink\Driver\DriverInterface, but is providedby the
Selenium2Driver. So, as Sauce uses selenium grid, this will only be usedwhen Sauce environment variables are set (other drivers do not have this).
I noticed this when trying to use
ChromeDriverinstead ofSelenium2Driver. We currently only support selenium, though.Description
Related Issue
Motivation and Context
Tried to make it work on
ChromeDriver.How Has This Been Tested?
Not Tested. Just moved the line inside the conditional check.
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: