[stable10] Get job id only if sauce environment variables are set#35008
Merged
Conversation
The `getWebDriverSession` is not part of the `Mink\Driver\DriverInterface`, but is provided by the `Selenium2Driver`. So, as Sauce uses selenium grid, this will only be used when Sauce environment variables are set (other drivers do not have this).
11 tasks
individual-it
approved these changes
Apr 12, 2019
skshetry
approved these changes
Apr 12, 2019
Codecov Report
@@ Coverage Diff @@
## stable10 #35008 +/- ##
==============================================
- Coverage 64.29% 64.29% -0.01%
Complexity 20040 20040
==============================================
Files 1285 1285
Lines 76824 76824
Branches 1307 1307
==============================================
- Hits 49394 49393 -1
- Misses 27049 27050 +1
Partials 381 381
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35008 +/- ##
==============================================
- Coverage 64.29% 64.29% -0.01%
Complexity 20040 20040
==============================================
Files 1285 1285
Lines 76824 76824
Branches 1307 1307
==============================================
- Hits 49394 49393 -1
- Misses 27049 27050 +1
Partials 381 381
Continue to review full report at Codecov.
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #35007