Use consistent app name in writeLog() calls

[phil-davis]

Description

Adjust writeLog() calls so they consistently use the name of the relevant "built in" app.

Motivation and Context

While looking at PR #35041 I noticed that some of the writeLog() calls had "varied" values for the app name parameter.

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #35044 into master will not change coverage.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master   #35044   +/-   ##
=========================================
  Coverage     65.37%   65.37%           
  Complexity    18622    18622           
=========================================
  Files          1215     1215           
  Lines         70510    70510           
  Branches       1295     1295           
=========================================
  Hits          46095    46095           
  Misses        24041    24041           
  Partials        374      374

Flag	Coverage Δ	Complexity Δ
#javascript	52.85% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.81% <33.33%> (ø)	18622 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/files_trashbin/ajax/undelete.php	0% <0%> (ø)	0 <0> (ø)	⬇️
apps/files_trashbin/ajax/delete.php	0% <0%> (ø)	0 <0> (ø)	⬇️
apps/files_sharing/lib/Helper.php	15.03% <0%> (ø)	46 <0> (ø)	⬇️
...haring/lib/Controller/RequestHandlerController.php	82.18% <66.66%> (ø)	30 <0> (ø)	⬇️
apps/files_sharing/lib/SharedMount.php	93.51% <66.66%> (ø)	33 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a9226...3fde5a8. Read the comment docs.

[codecov]

Codecov Report

Merging #35044 into master will not change coverage.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master   #35044   +/-   ##
=========================================
  Coverage     65.37%   65.37%           
  Complexity    18622    18622           
=========================================
  Files          1215     1215           
  Lines         70510    70510           
  Branches       1295     1295           
=========================================
  Hits          46095    46095           
  Misses        24041    24041           
  Partials        374      374

Flag	Coverage Δ	Complexity Δ
#javascript	52.85% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.81% <33.33%> (ø)	18622 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/files_trashbin/ajax/undelete.php	0% <0%> (ø)	0 <0> (ø)	⬇️
apps/files_trashbin/ajax/delete.php	0% <0%> (ø)	0 <0> (ø)	⬇️
apps/files_sharing/lib/Helper.php	15.03% <0%> (ø)	46 <0> (ø)	⬇️
...haring/lib/Controller/RequestHandlerController.php	82.18% <66.66%> (ø)	30 <0> (ø)	⬇️
apps/files_sharing/lib/SharedMount.php	93.51% <66.66%> (ø)	33 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a9226...3fde5a8. Read the comment docs.

[phil-davis]

Thius is only some changes to the text of parameters passed in writeLog() calls. I guess it fails codecov because not enough of those calls are currently covered by unit tests.

[phil-davis]

Backport stable10 #35049

[PVince81]

👍