Skip to content

Get translations from correct app#35041

Merged
PVince81 merged 4 commits into
masterfrom
get-translations-from-correct-app
Apr 18, 2019
Merged

Get translations from correct app#35041
PVince81 merged 4 commits into
masterfrom
get-translations-from-correct-app

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

Fixup the core apps so that they consistently lookup translations inside their "own" app.

Related Issue

Motivation and Context

If people have gone to the effort of adding translations in Transifex, then use them ;)

How Has This Been Tested?

Switch language to Deutsch and look on the UI for the "easy to make happen" text and confirm that it is translated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented Apr 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35041 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35041      +/-   ##
============================================
+ Coverage     65.37%   65.37%   +<.01%     
  Complexity    18622    18622              
============================================
  Files          1215     1215              
  Lines         70510    70510              
  Branches       1295     1295              
============================================
+ Hits          46095    46096       +1     
+ Misses        24041    24040       -1     
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 52.85% <66.66%> (ø) 0 <0> (ø) ⬇️
#phpunit 66.82% <ø> (ø) 18622 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_versions/js/versionstabview.js 80.41% <100%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/js/app.js 73.37% <50%> (ø) 0 <0> (ø) ⬇️
lib/private/Server.php 86.68% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a9226...bb5b300. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Apr 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35041 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35041      +/-   ##
============================================
+ Coverage     65.37%   65.37%   +<.01%     
  Complexity    18622    18622              
============================================
  Files          1215     1215              
  Lines         70510    70510              
  Branches       1295     1295              
============================================
+ Hits          46095    46096       +1     
+ Misses        24041    24040       -1     
  Partials        374      374
Flag Coverage Δ Complexity Δ
#javascript 52.85% <66.66%> (ø) 0 <0> (ø) ⬇️
#phpunit 66.82% <ø> (ø) 18622 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_versions/js/versionstabview.js 80.41% <100%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/js/app.js 73.37% <50%> (ø) 0 <0> (ø) ⬇️
lib/private/Server.php 86.68% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a9226...bb5b300. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport stable10 #35043

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
PVince81 merged commit 8b02b6f into master Apr 18, 2019
@PVince81
PVince81 deleted the get-translations-from-correct-app branch April 18, 2019 07:18
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Built-in core apps have some mixed translation reference

2 participants