Skip to content

[stable10] Wrong translation file referenced for accept & decline share#35045

Merged
phil-davis merged 1 commit into
owncloud:stable10from
jmdeboer-surfsara:stable10
Apr 17, 2019
Merged

[stable10] Wrong translation file referenced for accept & decline share#35045
phil-davis merged 1 commit into
owncloud:stable10from
jmdeboer-surfsara:stable10

Conversation

@jmdeboer-surfsara

Copy link
Copy Markdown
Contributor

Description

The strings for 'Accept Share' and 'Decline Share' are not translated.

These string live in apps/files_sharing/js/app.js
The translation for the strings is in apps/files_sharing/l10n/

However, in the code it says:
displayName: t('files', 'Decline Share')

So the string is searched for in the wrong file. Changed it to
displayName: t('files_sharing', 'Decline Share')

Motivation and Context

See above

How Has This Been Tested?

Tested on local installation

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@phil-davis phil-davis changed the title Wrong translation file referenced for accept & decline share [stable10] Wrong translation file referenced for accept & decline share Apr 17, 2019
@phil-davis

Copy link
Copy Markdown
Contributor

Backport of #35038

@codecov

codecov Bot commented Apr 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35045 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35045   +/-   ##
===========================================
  Coverage       64.46%   64.46%           
  Complexity      20064    20064           
===========================================
  Files            1286     1286           
  Lines           76928    76928           
  Branches         1307     1307           
===========================================
  Hits            49594    49594           
  Misses          26953    26953           
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.68% <ø> (ø) 20064 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/js/app.js 73.37% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ada5c...e02669c. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Apr 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35045 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35045   +/-   ##
===========================================
  Coverage       64.46%   64.46%           
  Complexity      20064    20064           
===========================================
  Files            1286     1286           
  Lines           76928    76928           
  Branches         1307     1307           
===========================================
  Hits            49594    49594           
  Misses          26953    26953           
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.68% <ø> (ø) 20064 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/js/app.js 73.37% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ada5c...e02669c. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor

@jmdeboer-surfsara thanks

@phil-davis
phil-davis merged commit 27bb6be into owncloud:stable10 Apr 17, 2019
@PVince81 PVince81 added this to the development milestone Apr 18, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants