Skip to content

[10.2] Wrong translation file referenced for accept & decline share#35063

Merged
PVince81 merged 6 commits into
release-10.2.0from
translation-release-10.2.0
Apr 18, 2019
Merged

[10.2] Wrong translation file referenced for accept & decline share#35063
PVince81 merged 6 commits into
release-10.2.0from
translation-release-10.2.0

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

Backport into 10.2 release:
PR #35045 Wrong translation file referenced for accept & decline share
PR #35043 Get translations from correct app
PR #35049 Use consistent app name in writeLog() calls

How Has This Been Tested?

Observing some translations in the webUI

@phil-davis
phil-davis requested a review from PVince81 April 18, 2019 08:58
@phil-davis phil-davis self-assigned this Apr 18, 2019

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov

codecov Bot commented Apr 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35063 into release-10.2.0 will not change coverage.
The diff coverage is 40%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release-10.2.0   #35063   +/-   ##
=================================================
  Coverage             64.29%   64.29%           
  Complexity            20040    20040           
=================================================
  Files                  1285     1285           
  Lines                 76824    76824           
  Branches               1307     1307           
=================================================
  Hits                  49393    49393           
  Misses                27050    27050           
  Partials                381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <66.66%> (ø) 0 <0> (ø) ⬇️
#phpunit 65.49% <33.33%> (ø) 20040 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/ajax/undelete.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_trashbin/ajax/delete.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/lib/Helper.php 20.89% <0%> (ø) 47 <0> (ø) ⬇️
apps/files_versions/js/versionstabview.js 80.41% <100%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/js/app.js 73.37% <50%> (ø) 0 <0> (ø) ⬇️
...haring/lib/Controller/RequestHandlerController.php 82.18% <66.66%> (ø) 30 <0> (ø) ⬇️
apps/files_sharing/lib/SharedMount.php 93.51% <66.66%> (ø) 33 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7b738...0f6fa7c. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Apr 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35063 into release-10.2.0 will not change coverage.
The diff coverage is 40%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release-10.2.0   #35063   +/-   ##
=================================================
  Coverage             64.29%   64.29%           
  Complexity            20040    20040           
=================================================
  Files                  1285     1285           
  Lines                 76824    76824           
  Branches               1307     1307           
=================================================
  Hits                  49393    49393           
  Misses                27050    27050           
  Partials                381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <66.66%> (ø) 0 <0> (ø) ⬇️
#phpunit 65.49% <33.33%> (ø) 20040 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/ajax/undelete.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_trashbin/ajax/delete.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/lib/Helper.php 20.89% <0%> (ø) 47 <0> (ø) ⬇️
apps/files_versions/js/versionstabview.js 80.41% <100%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/js/app.js 73.37% <50%> (ø) 0 <0> (ø) ⬇️
...haring/lib/Controller/RequestHandlerController.php 82.18% <66.66%> (ø) 30 <0> (ø) ⬇️
apps/files_sharing/lib/SharedMount.php 93.51% <66.66%> (ø) 33 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7b738...0f6fa7c. Read the comment docs.

@PVince81
PVince81 merged commit 4a80725 into release-10.2.0 Apr 18, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the translation-release-10.2.0 branch April 18, 2019 10:05
@PVince81 PVince81 added this to the QA milestone May 2, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants