[10.2.0] Backport of Remove share permission check from the file up…#35082
Merged
PVince81 merged 1 commit intoApr 23, 2019
Merged
Conversation
…load Remove share permission check from the file upload js file. Signed-off-by: Sujith H <sharidasan@owncloud.com>
Contributor
Author
|
Original PR #35060 |
11 tasks
PVince81
changed the title
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35082 +/- ##
=================================================
Coverage 64.29% 64.29%
Complexity 20040 20040
=================================================
Files 1285 1285
Lines 76824 76824
Branches 1307 1307
=================================================
Hits 49394 49394
Misses 27049 27049
Partials 381 381
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35082 +/- ##
=================================================
Coverage 64.29% 64.29%
Complexity 20040 20040
=================================================
Files 1285 1285
Lines 76824 76824
Branches 1307 1307
=================================================
Hits 49394 49394
Misses 27049 27049
Partials 381 381
Continue to review full report at Codecov.
|
delete-merged-branch
Bot
deleted the
remove-sharepermission-check-release-10.2.0
branch
April 23, 2019 11:52
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…load
Remove share permission check from the file upload
js file.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
Remove
sharePermissionchecks from the file-upload.js. We are no where using it and there is a problem in the code due to this. When we know its a file, we just have to check the fileinfo ( in the if condition ). The problem this PR tries to address is, when files are uploaded, the file information should be shown. Instead of this, the directory information was shown.This also fixes the cancel button problem in the conflict dialog. The cancel button clicked once cancels the conflict dialog.
Related Issue
Motivation and Context
Remove sharePermission checks from the file-upload.js file. This solves 2 problems:
How Has This Been Tested?
Cancelbutton of conflict dialog works correctly.Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: