Skip to content

[stable10] Backport of Remove share permission check from the file upload#35109

Closed
phil-davis wants to merge 1 commit into
stable10from
stable10-remove-sharepermission-check
Closed

[stable10] Backport of Remove share permission check from the file upload#35109
phil-davis wants to merge 1 commit into
stable10from
stable10-remove-sharepermission-check

Conversation

@phil-davis

@phil-davis phil-davis commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

Backport #35060
so that stable10 QA tarball is more up-to-date

Note: has also been backported to release-10.2.0 in PR #35082

…load

Remove share permission check from the file upload
js file.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@codecov

codecov Bot commented Apr 27, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35109 into stable10 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35109      +/-   ##
==============================================
+ Coverage       64.46%   64.46%   +<.01%     
  Complexity      20064    20064              
==============================================
  Files            1286     1286              
  Lines           76928    76928              
  Branches         1307     1307              
==============================================
+ Hits            49594    49595       +1     
+ Misses          26953    26952       -1     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.68% <ø> (ø) 20064 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 86.66% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f5a04...4611c88. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Apr 27, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35109 into stable10 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35109      +/-   ##
==============================================
+ Coverage       64.46%   64.46%   +<.01%     
  Complexity      20064    20064              
==============================================
  Files            1286     1286              
  Lines           76928    76928              
  Branches         1307     1307              
==============================================
+ Hits            49594    49595       +1     
+ Misses          26953    26952       -1     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.68% <ø> (ø) 20064 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 86.66% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f5a04...4611c88. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor Author

This happened in #35082 to release-10.2.0

@phil-davis phil-davis closed this May 28, 2019
@phil-davis
phil-davis deleted the stable10-remove-sharepermission-check branch May 28, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants