Skip to content

Test Helper to read file from server#35151

Merged
individual-it merged 1 commit into
masterfrom
readFileFromServerHelper
May 6, 2019
Merged

Test Helper to read file from server#35151
individual-it merged 1 commit into
masterfrom
readFileFromServerHelper

Conversation

@individual-it

Copy link
Copy Markdown
Member

Description

easy way to read a file on the sever

needed for owncloud/firstrunwizard#105

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented May 6, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35151 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35151      +/-   ##
============================================
+ Coverage     65.48%   65.49%   +<.01%     
  Complexity    18636    18636              
============================================
  Files          1217     1217              
  Lines         70536    70536              
  Branches       1296     1296              
============================================
+ Hits          46191    46195       +4     
+ Misses        23968    23964       -4     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.5% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.87% <ø> (ø) 18636 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 86.68% <0%> (+0.11%) 253% <0%> (ø) ⬇️
lib/private/Files/Storage/DAV.php 81.09% <0%> (+0.63%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e8578...38d5557. Read the comment docs.

@dpakach

dpakach commented May 6, 2019

Copy link
Copy Markdown
Contributor

Looks good 👍

@individual-it
individual-it merged commit 34be4d5 into master May 6, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the readFileFromServerHelper branch May 6, 2019 10:39
@individual-it

Copy link
Copy Markdown
Member Author

backport in #35158

@lock lock Bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants