add acceptance test for changing contents of Firstrunwizard#105
Merged
Conversation
individual-it
requested review from
dpakach,
paurakhsharma,
phil-davis and
skshetry
May 6, 2019 04:50
11 tasks
Member
|
needs owncloud/core#35151 to be merged |
skshetry
reviewed
May 6, 2019
| * | ||
| * @param $expectedMessage | ||
| * | ||
| * @Throws Exception |
There was a problem hiding this comment.
Suggested change
| * @Throws Exception | |
| * @throws Exception |
skshetry
reviewed
May 6, 2019
| } | ||
|
|
||
| /** | ||
| * Returns the message from firstrunwizard at heading |
There was a problem hiding this comment.
Suggested change
| * Returns the message from firstrunwizard at heading | |
| * Returns the message from firstrunwizard at heading |
dpakach
reviewed
May 6, 2019
| private $firstrunwizardPage; | ||
|
|
||
| /** | ||
| * @var PathofWizardFileFromServerRoot |
Contributor
There was a problem hiding this comment.
I dont think this is required
Contributor
There was a problem hiding this comment.
same goes for following variable declerations.
dpakach
reviewed
May 6, 2019
| @@ -0,0 +1,24 @@ | |||
| @webUI @insulated @disablePreviews | |||
| Feature: default message from firstrunwizard is displayed after changing default popup message of firstrunwizard and reverting it back | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Feature: default message from firstrunwizard is displayed after changing default popup message of firstrunwizard and reverting it back | |
| Feature: Customize firstrunwizard popup |
dpakach
reviewed
May 6, 2019
| @webUI @insulated @disablePreviews | ||
| Feature: default message from firstrunwizard is displayed after changing default popup message of firstrunwizard and reverting it back | ||
| As an administrator | ||
| I want to check if firstrunwizard displays default message on popup after changing the default message and reverting it |
Contributor
There was a problem hiding this comment.
Suggested change
| I want to check if firstrunwizard displays default message on popup after changing the default message and reverting it | |
| I want to customize firstrunwizard popup message |
dpakach
reviewed
May 6, 2019
| Feature: default message from firstrunwizard is displayed after changing default popup message of firstrunwizard and reverting it back | ||
| As an administrator | ||
| I want to check if firstrunwizard displays default message on popup after changing the default message and reverting it | ||
| So that I can manipulate and send popup message from firstrunwizard to new users |
Contributor
There was a problem hiding this comment.
Suggested change
| So that I can manipulate and send popup message from firstrunwizard to new users | |
| So that I can send message from firstrunwizard to all new users |
bhawanaprasain
force-pushed
the
contentchanger
branch
from
May 7, 2019 03:39
6e7c3de to
8833aa4
Compare
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=========================================
Coverage 28.07% 28.07%
Complexity 16 16
=========================================
Files 9 9
Lines 114 114
=========================================
Hits 32 32
Misses 82 82Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=========================================
Coverage 28.07% 28.07%
Complexity 16 16
=========================================
Files 9 9
Lines 114 114
=========================================
Hits 32 32
Misses 82 82Continue to review full report at Codecov.
|
bhawanaprasain
force-pushed
the
contentchanger
branch
from
May 7, 2019 06:44
8833aa4 to
6daf7b1
Compare
dpakach
reviewed
May 7, 2019
| private $pathOfWizardFileFromServerRoot = "/apps/firstrunwizard/templates/wizard.php"; | ||
|
|
||
| /** | ||
| * @var FileContent |
Contributor
There was a problem hiding this comment.
Suggested change
| * @var FileContent | |
| * @var string |
dpakach
reviewed
May 7, 2019
|
|
||
| /** | ||
| * @Then the user should not see the firstrunwizard popup message | ||
| * @Then the user should see the firstrunwizard popup message in general settings page |
Contributor
There was a problem hiding this comment.
2 Then steps on same function?
dpakach
reviewed
May 7, 2019
| } | ||
|
|
||
| /** | ||
| * @When the user clicks :arg1 button |
bhawanaprasain
force-pushed
the
contentchanger
branch
2 times, most recently
from
May 7, 2019 09:06
914f5fa to
60c4c8b
Compare
skshetry
reviewed
May 7, 2019
| $headingMessage = $this->firstRunWizardPage->getHeadingMessage(); | ||
|
|
||
| PHPUnit\Framework\Assert::assertSame( | ||
| $expectedMessage, $headingMessage, "Firstrunwizard was expected to show $expectedMessage but showed $headingMessage." |
There was a problem hiding this comment.
Too long, please separate into multiple lines.
bhawanaprasain
force-pushed
the
contentchanger
branch
2 times, most recently
from
May 8, 2019 03:38
0b9fa8a to
50579a5
Compare
skshetry
reviewed
May 8, 2019
| protected $firstrunwizardPopupXpath = "//*[@id='firstrunwizard']"; | ||
|
|
||
| protected $headingMessageXpath = "//*[@id='firstrunwizard']/h1"; | ||
| protected $firstRunWizardXpath = "//*[@id='firstrunwizard']"; |
There was a problem hiding this comment.
Suggested change
| protected $firstRunWizardXpath = "//*[@id='firstrunwizard']"; | |
| protected $firstRunWizardXpath = "//*[@id='firstrunwizard']"; | |
bhawanaprasain
force-pushed
the
contentchanger
branch
from
May 8, 2019 04:18
50579a5 to
b28478b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code allows administrator to change the default popup message of firstrunwizard and revert the popup message back to default message .