feature test for share autocomplete list in webUI#35153
Merged
phil-davis merged 1 commit intoMay 14, 2019
Conversation
dpakach
reviewed
May 6, 2019
dpakach
reviewed
May 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #35153 +/- ##
============================================
+ Coverage 65.48% 65.49% +<.01%
Complexity 18636 18636
============================================
Files 1217 1217
Lines 70536 70536
Branches 1296 1296
============================================
+ Hits 46194 46195 +1
+ Misses 23965 23964 -1
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35153 +/- ##
=========================================
Coverage 65.53% 65.53%
Complexity 18645 18645
=========================================
Files 1218 1218
Lines 70540 70540
Branches 1288 1288
=========================================
Hits 46231 46231
Misses 23932 23932
Partials 377 377
Continue to review full report at Codecov.
|
dpakach
requested review from
individual-it,
paurakhsharma,
phil-davis and
skshetry
skshetry
reviewed
May 10, 2019
skshetry
reviewed
May 10, 2019
paurakhsharma
previously approved these changes
May 13, 2019
paurakhsharma
left a comment
paurakhsharma
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me 👍
individual-it
requested changes
May 14, 2019
individual-it
left a comment
individual-it
left a comment
Member
There was a problem hiding this comment.
add tests
- to check if user has disallowed autocompleting but sharer types full username
- to check if typing full display name when autocompletion is disabled (admin and user)
Contributor
Author
|
backport on #35217 |
individual-it
approved these changes
May 14, 2019
Member
|
@ownclouders rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test for autocompletion feature in share dialog using webUI.
Includes test for allowing user to opt-out of autocomplete in sharing dialog #34942
and admin disabling share dialog user enumeration
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: