Skip to content

Split long-running api acceptance suites#35170

Merged
phil-davis merged 4 commits into
masterfrom
split-api-acceptance-suites-20190508
May 8, 2019
Merged

Split long-running api acceptance suites#35170
phil-davis merged 4 commits into
masterfrom
split-api-acceptance-suites-20190508

Conversation

@phil-davis

@phil-davis phil-davis commented May 8, 2019

Copy link
Copy Markdown
Contributor

Description

Split api acceptance test suites:

apiAuth add apiAuthOcs (the ocs tests to a bit more than half the time)
apiProvisioning-v1 add apiProvisioningGroups-v1 (the group-related tests took about half the time)
apiProvisioning-v2 add apiProvisioningGroups-v2 (the group-related tests took about half the time)
apiShareManagement add apiShareManagementBasic (which has create/update/delete)
apiWebdavLocks add apiWebdavLocks2 (there seemed to be no nice logical grouping of these to split out into smaller suites)

Motivation and Context

The following api acceptance test suites are nowadays taking more than 1 hour to complete:

apiAuth
apiProvisioning-v1
apiProvisioning-v2
apiShareManagement
apiWebdavLocks

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis requested a review from individual-it May 8, 2019 02:25
@phil-davis phil-davis self-assigned this May 8, 2019
@phil-davis phil-davis changed the title Split lon g-running api acceptance suites Split long-running api acceptance suites May 8, 2019
@phil-davis

phil-davis commented May 8, 2019

Copy link
Copy Markdown
Contributor Author

Firefox webUI failed with the jQuery problem:
https://drone.owncloud.com/owncloud/core/17194/910

I restarted drone.

@phil-davis

Copy link
Copy Markdown
Contributor Author

Longest acceptance test suite is now about 40 minutes, which is similar to the longest phpunit test run with Oracle.

@codecov

codecov Bot commented May 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35170   +/-   ##
=========================================
  Coverage     65.48%   65.48%           
  Complexity    18636    18636           
=========================================
  Files          1217     1217           
  Lines         70535    70535           
  Branches       1296     1296           
=========================================
  Hits          46193    46193           
  Misses        23965    23965           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.5% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.87% <ø> (ø) 18636 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37853a...2af9ffc. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35170   +/-   ##
=========================================
  Coverage     65.48%   65.48%           
  Complexity    18636    18636           
=========================================
  Files          1217     1217           
  Lines         70535    70535           
  Branches       1296     1296           
=========================================
  Hits          46193    46193           
  Misses        23965    23965           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.5% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.87% <ø> (ø) 18636 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37853a...2af9ffc. Read the comment docs.

@phil-davis phil-davis merged commit 1d077f7 into master May 8, 2019
@delete-merged-branch delete-merged-branch Bot deleted the split-api-acceptance-suites-20190508 branch May 8, 2019 06:00
@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport stable10 #35173

@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants