Skip to content

Email change test improvements#411

Merged
individual-it merged 3 commits into
masterfrom
emailChangeSync
May 8, 2019
Merged

Email change test improvements#411
individual-it merged 3 commits into
masterfrom
emailChangeSync

Conversation

@individual-it

Copy link
Copy Markdown
Member

small improvements to the testing code

# And the email address of user "user1" should be "ldapuser@oc.com"
And the email address of user "user1" should be "apiuser@example.com"
And the LDAP users are resynced
And the email address of user "user1" should be "ldapuser@oc.com"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this fixed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it broken?
the admin still can overwrite the setting owncloud/core#33186 but when synced the correct LDAP setting will come back

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just asked as it was commented before.

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wanted a clarification.

@phil-davis

phil-davis commented May 7, 2019

Copy link
Copy Markdown
Contributor

drone apiAuth job was cancelled after running for 3 hours.
I restarted it.
We need to see why that suite (from core) is taking so long to run nowadays.
(see owncloud/core#35170 which splits the suite)

@codecov

codecov Bot commented May 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #411 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #411   +/-   ##
=========================================
  Coverage     34.94%   34.94%           
  Complexity     1327     1327           
=========================================
  Files            31       31           
  Lines          3780     3780           
=========================================
  Hits           1321     1321           
  Misses         2459     2459

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a615c62...8d8424f. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #411 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #411   +/-   ##
=========================================
  Coverage     34.94%   34.94%           
  Complexity     1327     1327           
=========================================
  Files            31       31           
  Lines          3780     3780           
=========================================
  Hits           1321     1321           
  Misses         2459     2459

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a615c62...8d8424f. Read the comment docs.

@individual-it
individual-it merged commit 038e42a into master May 8, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the emailChangeSync branch May 8, 2019 03:47
@patrickjahns patrickjahns added this to the development milestone Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants