feature test for public link share expiration date deletion#35175
Merged
Conversation
paurakhsharma
requested review from
dpakach,
individual-it,
paurakhsharma and
skshetry
and removed request for
dpakach and
individual-it
Codecov Report
@@ Coverage Diff @@
## master #35175 +/- ##
============================================
- Coverage 65.48% 65.48% -0.01%
Complexity 18636 18636
============================================
Files 1217 1217
Lines 70535 70535
Branches 1296 1296
============================================
- Hits 46193 46189 -4
- Misses 23965 23969 +4
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35175 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
paurakhsharma
left a comment
paurakhsharma
left a comment
Contributor
There was a problem hiding this comment.
Some small suggestions
skshetry
reviewed
May 8, 2019
skshetry
reviewed
May 10, 2019
skshetry
reviewed
May 10, 2019
skshetry
reviewed
May 10, 2019
individual-it
requested changes
May 14, 2019
individual-it
requested changes
May 15, 2019
| if (!$this->isFieldInResponse($field, $value)) { | ||
| PHPUnit\Framework\Assert::fail( | ||
| "$field doesn't have value $value" | ||
| if ($value != null) { |
Member
There was a problem hiding this comment.
Suggested change
| if ($value != null) { | |
| if ($value !== null) { |
Contributor
Author
There was a problem hiding this comment.
since we are changing the expiration to " " which is empty string(not null) it's better to use (!empty($value))
| * @throws ElementNotFoundException | ||
| */ | ||
| public function getErrorMessage() { | ||
| $errorMessageElement = $this->popupElement->find("xpath", $this->expirationDateRequiredErrorMessageXpath); |
Member
There was a problem hiding this comment.
please make the line shorter / break it
10 tasks
individual-it
requested changes
May 15, 2019
| ); | ||
| } | ||
| } else { | ||
| PHPUnit\Framework\Assert::assertFalse( |
Member
There was a problem hiding this comment.
this logic does not look correct to me. We expect the field to be in the response and be empty, so isFieldInResponse() should return true
Member
|
@haribhandari07 please fix the conflicts and ping me again for review |
individual-it
approved these changes
May 24, 2019
individual-it
added
backport-request
4 - To release
dev:acceptance-tests
and removed
3 - To Review
labels
Member
|
@haribhandari07 please backport to stable10 |
This was referenced May 30, 2019
Contributor
Author
|
Backport on #35369 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Includes two tests for deletion of expiration date when the expiration date is not enforced and enforced.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: