Skip to content

Acceptance test for renaming folders with different path in Shared B…#35202

Merged
individual-it merged 2 commits into
owncloud:masterfrom
bhawanaprasain:sharedbylink
May 15, 2019
Merged

Acceptance test for renaming folders with different path in Shared B…#35202
individual-it merged 2 commits into
owncloud:masterfrom
bhawanaprasain:sharedbylink

Conversation

@bhawanaprasain

Copy link
Copy Markdown
Contributor

Description

If a user tries to rename a folder with the name of one of the enlisted folders having different path in shared by link section then the user cannot rename the folder with the name of enlisted folders.

Related Issue

Issue : #35174

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov

codecov Bot commented May 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35202 into master will increase coverage by 16.66%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #35202       +/-   ##
=============================================
+ Coverage     48.87%   65.53%   +16.66%     
- Complexity        0    18644    +18644     
=============================================
  Files           109     1218     +1109     
  Lines         10560    70539    +59979     
  Branches       1288     1288               
=============================================
+ Hits           5161    46230    +41069     
- Misses         5022    23932    +18910     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (+28.72%) 18644 <ø> (+18644) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/config.php 10.71% <0%> (-20.87%) 19% <0%> (+19%)
apps/updatenotification/templates/admin.php 0% <0%> (ø) 0% <0%> (?)
lib/private/Encryption/Keys/Storage.php 88.03% <0%> (ø) 48% <0%> (?)
lib/private/App/CodeChecker/NodeVisitor.php 95.86% <0%> (ø) 54% <0%> (?)
lib/private/RedisFactory.php 0% <0%> (ø) 19% <0%> (?)
apps/dav/lib/Avatars/AvatarNode.php 72% <0%> (ø) 9% <0%> (?)
...s/dav/appinfo/Migrations/Version20170202213905.php 21.05% <0%> (ø) 12% <0%> (?)
apps/dav/lib/Upload/ChunkLocationProvider.php 100% <0%> (ø) 4% <0%> (?)
apps/files/lib/AppInfo/Application.php 40.47% <0%> (ø) 7% <0%> (?)
apps/systemtags/list.php 0% <0%> (ø) 0% <0%> (?)
... and 1101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e920e3...4c7b457. Read the comment docs.

@codecov

codecov Bot commented May 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35202   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18645    18645           
=========================================
  Files          1218     1218           
  Lines         70540    70540           
  Branches       1288     1288           
=========================================
  Hits          46231    46231           
  Misses        23932    23932           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18645 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e920e3...da1e1de. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor

Backport stable10 #35175

@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants