Treat send attempt as unsuccessful when there is a message.

[VicDeo]

Description

result.ocs.meta.status is 200 when the email was not sent.

Related Issue

• Fixes Sharer gets "Email notification was sent!" message even when the email was not sent #35218

Motivation and Context

Frontend says that email is successfully sent even when it has been not sent.

How Has This Been Tested?

See #35218

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[VicDeo]

10.2.0: #35221

[codecov]

Codecov Report

Merging #35220 into master will decrease coverage by <.01%.
The diff coverage is 12.5%.

@@             Coverage Diff              @@
##             master   #35220      +/-   ##
============================================
- Coverage     65.53%   65.53%   -0.01%     
  Complexity    18645    18645              
============================================
  Files          1218     1218              
  Lines         70540    70542       +2     
  Branches       1288     1288              
============================================
  Hits          46231    46231              
- Misses        23932    23934       +2     
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	53.69% <100%> (ø)	0 <0> (ø)	⬇️
#phpunit	66.89% <0%> (-0.01%)	18645 <0> (ø)

Impacted Files	Coverage Δ	Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php	87.27% <0%> (-0.32%)	204 <0> (ø)
core/js/sharedialogshareelistview.js	80.48% <100%> (ø)	0 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e920e3...b9c9eb5. Read the comment docs.

[VicDeo]

@PVince81 is it better now?

[paurakhsharma]

Acceptance test related to this feature is here: #35215

[PVince81]

@VicDeo yes.

would be good to update unit tests where possible

[PVince81]

👍