Skip to content

Unskip behat step and remove issue tag#35242

Merged
individual-it merged 1 commit into
masterfrom
unskipp-bheat-step-mail-notification
May 16, 2019
Merged

Unskip behat step and remove issue tag#35242
individual-it merged 1 commit into
masterfrom
unskipp-bheat-step-mail-notification

Conversation

@paurakhsharma

Copy link
Copy Markdown
Contributor

Description

Since the issue is fixed on #35220 tests are starting to fail on drone (as expected)
So, make the changes to the tests accordingly.

Related Issue

#35218

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov

codecov Bot commented May 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35242   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e58413...7c9fac9. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35242   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e58413...7c9fac9. Read the comment docs.

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@individual-it

Copy link
Copy Markdown
Member

The fix was created before the original tests were created and CI was not rerun when the tests were added. So the needed test-change was unnoticed when merging the fix

@individual-it individual-it merged commit fa3bfcb into master May 16, 2019
@delete-merged-branch delete-merged-branch Bot deleted the unskipp-bheat-step-mail-notification branch May 16, 2019 08:16
@paurakhsharma

Copy link
Copy Markdown
Contributor Author

release-10.2.0: #35240

@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants