Skip to content

Add api acceptance test for checking that the sensitive data are not exposed by ocs api on share#35233

Merged
dpakach merged 1 commit into
masterfrom
test-share-sensitive-data
May 17, 2019
Merged

Add api acceptance test for checking that the sensitive data are not exposed by ocs api on share#35233
dpakach merged 1 commit into
masterfrom
test-share-sensitive-data

Conversation

@dpakach

@dpakach dpakach commented May 15, 2019

Copy link
Copy Markdown
Contributor

Description

Add API acceptance test to check if the OCS API exposes sensitive information.

Related Issue

Motivation and Context

This was a newly added change in #34691

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@dpakach dpakach force-pushed the test-share-sensitive-data branch from d7fd3aa to b1280f2 Compare May 16, 2019 05:51
@codecov

codecov Bot commented May 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35233 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35233   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70544    70544           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23931    23931           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a74c47...b1280f2. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35233 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35233   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70544    70544           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23931    23931           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a74c47...b1280f2. Read the comment docs.

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@individual-it

Copy link
Copy Markdown
Member

could add tests when getting the shares by api https://doc.owncloud.com/server/10.1/developer_manual/core/ocs-share-api.html#get-all-shares
but can be done in new PR

@dpakach

dpakach commented May 17, 2019

Copy link
Copy Markdown
Contributor Author

Backport on #35251

@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Acceptance test: Don't expose hashed password in OCS api

4 participants