Skip to content

[Stable10] Add api acceptance test for checking that the sensitive data are not exposed by ocs api on share#35251

Merged
individual-it merged 1 commit into
stable10from
stable10-test-share-sensitive-data
May 17, 2019
Merged

[Stable10] Add api acceptance test for checking that the sensitive data are not exposed by ocs api on share#35251
individual-it merged 1 commit into
stable10from
stable10-test-share-sensitive-data

Conversation

@dpakach

@dpakach dpakach commented May 17, 2019

Copy link
Copy Markdown
Contributor

Backport for #35233

@dpakach dpakach self-assigned this May 17, 2019
@dpakach dpakach changed the title [Stable] Add api acceptance test for checking that the sensitive data are not exposed by ocs api on share [Stable10] Add api acceptance test for checking that the sensitive data are not exposed by ocs api on share May 17, 2019
@dpakach dpakach mentioned this pull request May 17, 2019
Merged
11 tasks
phil-davis
phil-davis approved these changes May 17, 2019
View reviewed changes
Comment thread tests/acceptance/features/apiShareManagementBasic/createShare.feature
| 2 | 200 |

@public_link_share-feature-required
Scenario Outline: Getting the share information of public link share form OCS API does not expose sensitive information

@phil-davis phil-davis May 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the backport, so do not change it here. But some time

s/form/from

in the scenario description

@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35251 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35251   +/-   ##
===========================================
  Coverage       64.52%   64.52%           
  Complexity      20080    20080           
===========================================
  Files            1289     1289           
  Lines           76944    76944           
  Branches         1299     1299           
===========================================
  Hits            49648    49648           
  Misses          26915    26915           
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.72% <ø> (ø) 20080 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4978c27...ce38ead. Read the comment docs.

2 similar comments
@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35251 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35251   +/-   ##
===========================================
  Coverage       64.52%   64.52%           
  Complexity      20080    20080           
===========================================
  Files            1289     1289           
  Lines           76944    76944           
  Branches         1299     1299           
===========================================
  Hits            49648    49648           
  Misses          26915    26915           
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.72% <ø> (ø) 20080 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4978c27...ce38ead. Read the comment docs.

@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35251 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35251   +/-   ##
===========================================
  Coverage       64.52%   64.52%           
  Complexity      20080    20080           
===========================================
  Files            1289     1289           
  Lines           76944    76944           
  Branches         1299     1299           
===========================================
  Hits            49648    49648           
  Misses          26915    26915           
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.72% <ø> (ø) 20080 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4978c27...ce38ead. Read the comment docs.

@individual-it individual-it merged commit 52953a8 into stable10 May 17, 2019
@delete-merged-branch delete-merged-branch Bot deleted the stable10-test-share-sensitive-data branch May 17, 2019 06:25
@phil-davis phil-davis mentioned this pull request Jun 18, 2019
Merged
10 tasks
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@phil-davis phil-davis phil-davis approved these changes
@individual-it individual-it Awaiting requested review from individual-it
@skshetry skshetry Awaiting requested review from skshetry
@paurakhsharma paurakhsharma Awaiting requested review from paurakhsharma

Assignees

@dpakach dpakach

Labels

4 - To release dev:acceptance-tests QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpakach @phil-davis @individual-it