Skip to content

Acceptance test for group names with emoji#35247

Merged
individual-it merged 1 commit into
owncloud:masterfrom
bhawanaprasain:emoji
May 22, 2019
Merged

Acceptance test for group names with emoji#35247
individual-it merged 1 commit into
owncloud:masterfrom
bhawanaprasain:emoji

Conversation

@bhawanaprasain

@bhawanaprasain bhawanaprasain commented May 16, 2019 •
edited by phil-davis
Loading

Copy link
Copy Markdown
Contributor

Using these tests we can check if we can use group names with emojis .

Part of issue #34437

dpakach
dpakach reviewed May 16, 2019
View reviewed changes
Comment thread tests/acceptance/features/apiProvisioningGroups-v1/deleteGroup.feature
| 50%2Fix | %2F literal looks like an escaped slash |
| staff?group | Question mark |
| 😁 😂 | emoji |

@dpakach dpakach May 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

dpakach
dpakach reviewed May 16, 2019
View reviewed changes
Comment thread tests/acceptance/features/apiProvisioningGroups-v2/removeFromGroup.feature
| नेपाली | Unicode group name |

Scenario Outline: admin removes a user from a group
Scenario Outline: admin removes a user from a group

@dpakach dpakach May 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrectly indented

@individual-it individual-it mentioned this pull request May 16, 2019
Closed
5 tasks
@codecov

codecov Bot commented May 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35247 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35247   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dc3cd...aafa733. Read the comment docs.

@codecov

codecov Bot commented May 20, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #35247 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35247   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 86.57% <0%> (-0.12%) 253% <0%> (ø)
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dc3cd...fe875d7. Read the comment docs.

@individual-it

individual-it commented May 21, 2019

Copy link
Copy Markdown
Member

restarted build

@bhawanaprasain

bhawanaprasain commented May 21, 2019

Copy link
Copy Markdown
Contributor Author

@dpakach @paurakhsharma @skshetry please review again

paurakhsharma
paurakhsharma reviewed May 21, 2019
View reviewed changes

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@individual-it
individual-it merged commit 74ead9c into owncloud:master May 22, 2019
@individual-it

individual-it commented May 22, 2019

Copy link
Copy Markdown
Member

@bhawanaprasain please backport to stable10 branch

@bhawanaprasain bhawanaprasain mentioned this pull request May 22, 2019
Merged
6 tasks
@phil-davis

phil-davis commented May 29, 2019

Copy link
Copy Markdown
Contributor

Backport stable10 #35300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it approved these changes
@skshetry skshetry Awaiting requested review from skshetry
+2 more reviewers
@dpakach dpakach dpakach left review comments
@paurakhsharma paurakhsharma paurakhsharma left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@bhawanaprasain bhawanaprasain

Labels

3 - To Review dev:acceptance-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bhawanaprasain @individual-it @phil-davis @dpakach @paurakhsharma