[stable10] Acceptance test for group names with emoji#35300
Merged
Conversation
Contributor
Author
|
@paurakhsharma @skshetry @dpakach please review on my PR. |
individual-it
approved these changes
May 22, 2019
Member
|
@bhawanaprasain looks like we need to rebase this on stable10 |
a4dbb25 to
7fdd947
Compare
Codecov Report
@@ Coverage Diff @@
## stable10 #35300 +/- ##
==============================================
- Coverage 64.91% 64.64% -0.28%
Complexity 20089 20089
==============================================
Files 1226 1289 +63
Lines 69535 76943 +7408
Branches 0 1300 +1300
==============================================
+ Hits 45142 49738 +4596
- Misses 24393 26821 +2428
- Partials 0 384 +384
Continue to review full report at Codecov.
|
5 tasks
7fdd947 to
4334351
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport on #35247
Description
Using these tests we can check if we can create group names with emojis .
Part of issue #34437
Types of changes