Skip to content

[stable10] Acceptance test for group names with emoji#35300

Merged
individual-it merged 1 commit into
owncloud:stable10from
bhawanaprasain:stable10-emoji
May 24, 2019
Merged

[stable10] Acceptance test for group names with emoji#35300
individual-it merged 1 commit into
owncloud:stable10from
bhawanaprasain:stable10-emoji

Conversation

@bhawanaprasain

@bhawanaprasain bhawanaprasain commented May 22, 2019

Copy link
Copy Markdown
Contributor

Backport on #35247

Description

Using these tests we can check if we can create group names with emojis .

Part of issue #34437

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@bhawanaprasain

Copy link
Copy Markdown
Contributor Author

@paurakhsharma @skshetry @dpakach please review on my PR.

@individual-it

Copy link
Copy Markdown
Member

@bhawanaprasain looks like we need to rebase this on stable10

@codecov

codecov Bot commented May 23, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35300 into stable10 will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35300      +/-   ##
==============================================
- Coverage       64.91%   64.64%   -0.28%     
  Complexity      20089    20089              
==============================================
  Files            1226     1289      +63     
  Lines           69535    76943    +7408     
  Branches            0     1300    +1300     
==============================================
+ Hits            45142    49738    +4596     
- Misses          24393    26821    +2428     
- Partials            0      384     +384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.78% <ø> (+0.86%) 20089 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.82% <0%> (-9.19%) 74% <0%> (ø)
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3705219...4334351. Read the comment docs.

@bhawanaprasain bhawanaprasain changed the title [stable10-emoji] Acceptance test for group names with emoji [stable10] Acceptance test for group names with emoji May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants