Skip to content

Add exception page page object and its related steps in acceptance test#35265

Merged
dpakach merged 1 commit into
masterfrom
exception-page
May 21, 2019
Merged

Add exception page page object and its related steps in acceptance test#35265
dpakach merged 1 commit into
masterfrom
exception-page

Conversation

@dpakach

@dpakach dpakach commented May 20, 2019

Copy link
Copy Markdown
Contributor

Description

Add a new page object for General Exception page and its related steps for acceptance tests.

Related Issue

  • Fixes <issue_link>

Motivation and Context

We already had a page object for General Error page but the exception page is a bit different and required a new page object.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

/**
* ownCloud
*
* @author Artur Neumann <dipak@jankaritech.com>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @author Artur Neumann <dipak@jankaritech.com>
* @author Dipak Acharya <dipak@jankaritech.com>

@codecov

codecov Bot commented May 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35265   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dc3cd...bb00347. Read the comment docs.

@codecov

codecov Bot commented May 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35265   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 86.57% <0%> (-0.12%) 253% <0%> (ø)
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dc3cd...bb00347. Read the comment docs.

@individual-it

Copy link
Copy Markdown
Member

restarted drone build

@dpakach

dpakach commented May 22, 2019

Copy link
Copy Markdown
Contributor Author

Backport on #35281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants