Skip to content

Fix openFile method to handle error in acceptance tests#35268

Merged
individual-it merged 1 commit into
masterfrom
open-file-error
May 22, 2019
Merged

Fix openFile method to handle error in acceptance tests#35268
individual-it merged 1 commit into
masterfrom
open-file-error

Conversation

@dpakach

@dpakach dpakach commented May 20, 2019

Copy link
Copy Markdown
Contributor

Description

Modify the acceptance test method webUIFilesContext::openFile to handle errors that may occur while opening the file.

Related Issue

  • Fixes <issue_link>

Motivation and Context

The method originally only assumes that the operation will be always successful. But sometimes it may fail and in that case the file is not opened. So the method needed modification to handle the situations when the user opens the file expecting to fail.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@dpakach

dpakach commented May 20, 2019

Copy link
Copy Markdown
Contributor Author

Requires #35265 to be merged first.

@codecov

codecov Bot commented May 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35268 into master will decrease coverage by 16.66%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #35268       +/-   ##
=============================================
- Coverage     65.54%   48.87%   -16.67%     
=============================================
  Files          1218      109     -1109     
  Lines         70546    10560    -59986     
  Branches       1288     1288               
=============================================
- Hits          46236     5161    -41075     
+ Misses        23933     5022    -18911     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 38.17% <ø> (-28.73%) 0 <ø> (-18647)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dc3cd...499573e. Read the comment docs.

@codecov

codecov Bot commented May 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35268   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ead9c...c9a689d. Read the comment docs.

@dpakach dpakach force-pushed the open-file-error branch from 499573e to fa87fa2 Compare May 21, 2019 05:19

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpakach dpakach force-pushed the open-file-error branch 6 times, most recently from f1e7f36 to a49ecb5 Compare May 22, 2019 06:37

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpakach dpakach force-pushed the open-file-error branch from a49ecb5 to c9a689d Compare May 22, 2019 08:20
@dpakach

dpakach commented May 22, 2019

Copy link
Copy Markdown
Contributor Author

Backport on #35299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants