Fix openFile method to handle error in acceptance tests#35268
Merged
Conversation
Contributor
Author
|
Requires #35265 to be merged first. |
281f1c8 to
499573e
Compare
Codecov Report
@@ Coverage Diff @@
## master #35268 +/- ##
=============================================
- Coverage 65.54% 48.87% -16.67%
=============================================
Files 1218 109 -1109
Lines 70546 10560 -59986
Branches 1288 1288
=============================================
- Hits 46236 5161 -41075
+ Misses 23933 5022 -18911
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35268 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
f1e7f36 to
a49ecb5
Compare
individual-it
approved these changes
May 22, 2019
Contributor
Author
|
Backport on #35299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify the acceptance test method
webUIFilesContext::openFileto handle errors that may occur while opening the file.Related Issue
Motivation and Context
The method originally only assumes that the operation will be always successful. But sometimes it may fail and in that case the file is not opened. So the method needed modification to handle the situations when the user opens the file expecting to fail.
How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: