Skip to content

[Stable10]Add acceptance test for checking changing sharing permissions#35267

Closed
dpakach wants to merge 1 commit into
stable10from
stable10-test-issue-35155
Closed

[Stable10]Add acceptance test for checking changing sharing permissions#35267
dpakach wants to merge 1 commit into
stable10from
stable10-test-issue-35155

Conversation

@dpakach

@dpakach dpakach commented May 20, 2019

Copy link
Copy Markdown
Contributor

Backport for #35166

@phil-davis

Copy link
Copy Markdown
Contributor

There were random drone phpunit errors. I restarted drone.

@phil-davis phil-davis force-pushed the stable10-test-issue-35155 branch from ff3bd35 to fdbc4fb Compare May 20, 2019 21:35
@codecov

codecov Bot commented May 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35267 into stable10 will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35267      +/-   ##
==============================================
- Coverage       64.52%   64.16%   -0.37%     
  Complexity      20080    20080              
==============================================
  Files            1289     1289              
  Lines           76947    76913      -34     
  Branches         1299     1299              
==============================================
- Hits            49650    49349     -301     
- Misses          26916    27183     +267     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.32% <ø> (-0.41%) 20080 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php 0% <0%> (-86.67%) 8% <0%> (ø)
lib/private/Repair/Collation.php 0% <0%> (-82.5%) 12% <0%> (ø)
lib/private/Repair/InnoDB.php 0% <0%> (-78.95%) 6% <0%> (ø)
...ilder/ExpressionBuilder/MySqlExpressionBuilder.php 0% <0%> (-62.5%) 3% <0%> (ø)
lib/private/DB/MySQLMigrator.php 0% <0%> (-57.7%) 7% <0%> (ø)
lib/private/DB/AdapterMySQL.php 0% <0%> (-50%) 4% <0%> (ø)
lib/private/Files/Storage/Wrapper/Availability.php 10.38% <0%> (-40.26%) 80% <0%> (ø)
lib/private/Files/ObjectStore/NoopScanner.php 68.75% <0%> (-18.75%) 6% <0%> (ø)
lib/private/Preview/MP3.php 45.16% <0%> (-12.91%) 13% <0%> (ø)
...b/private/Files/ObjectStore/ObjectStoreStorage.php 71.42% <0%> (-12.36%) 95% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a964a1...fdbc4fb. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35267 into stable10 will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35267      +/-   ##
==============================================
- Coverage       64.52%   64.16%   -0.37%     
  Complexity      20080    20080              
==============================================
  Files            1289     1289              
  Lines           76947    76913      -34     
  Branches         1299     1299              
==============================================
- Hits            49650    49349     -301     
- Misses          26916    27183     +267     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.32% <ø> (-0.41%) 20080 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php 0% <0%> (-86.67%) 8% <0%> (ø)
lib/private/Repair/Collation.php 0% <0%> (-82.5%) 12% <0%> (ø)
lib/private/Repair/InnoDB.php 0% <0%> (-78.95%) 6% <0%> (ø)
...ilder/ExpressionBuilder/MySqlExpressionBuilder.php 0% <0%> (-62.5%) 3% <0%> (ø)
lib/private/DB/MySQLMigrator.php 0% <0%> (-57.7%) 7% <0%> (ø)
lib/private/DB/AdapterMySQL.php 0% <0%> (-50%) 4% <0%> (ø)
lib/private/Files/Storage/Wrapper/Availability.php 10.38% <0%> (-40.26%) 80% <0%> (ø)
lib/private/Files/ObjectStore/NoopScanner.php 68.75% <0%> (-18.75%) 6% <0%> (ø)
lib/private/Preview/MP3.php 45.16% <0%> (-12.91%) 13% <0%> (ø)
...b/private/Files/ObjectStore/ObjectStoreStorage.php 71.42% <0%> (-12.36%) 95% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a964a1...fdbc4fb. Read the comment docs.

@dpakach

dpakach commented May 21, 2019

Copy link
Copy Markdown
Contributor Author

PR will be made to branch release-10.2.0

@dpakach dpakach closed this May 21, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants