Add acceptance test for checking changing sharing permissions#35166
Merged
Conversation
dpakach
requested review from
individual-it,
paurakhsharma,
phil-davis and
skshetry
and removed request for
individual-it
skshetry
reviewed
May 8, 2019
| $name = \trim($name, $name[0]); | ||
| try { | ||
| $this->deleteTheFileUsingTheWebUI($name, false); | ||
| $retries = $expect ? 1 : null; |
skshetry
reviewed
May 8, 2019
| * @throws \Exception | ||
| */ | ||
| public function itShouldNotBePossibleToDeleteFileFolderUsingTheWebUI($name) { | ||
| public function itShouldNotBePossibleToDeleteFileFolderUsingTheWebUI($shouldOrNot, $name) { |
Contributor
There was a problem hiding this comment.
Can you split this function? It was too difficult for me to think about this.
Codecov Report
@@ Coverage Diff @@
## master #35166 +/- ##
============================================
- Coverage 65.53% 65.49% -0.05%
+ Complexity 18645 18636 -9
============================================
Files 1218 1217 -1
Lines 70540 70536 -4
Branches 1288 1296 +8
============================================
- Hits 46231 46195 -36
- Misses 23932 23964 +32
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35166 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
skshetry
reviewed
May 13, 2019
| * @throws \Exception | ||
| */ | ||
| public function optionShouldNotBeAvailable($action, $name, $shouldOrNot) { | ||
| $possible = $shouldOrNot !== "not"; |
dpakach
force-pushed
the
test-issue-35155
branch
3 times, most recently
from
ddbcd3b to
da02f0c
Compare
skshetry
reviewed
May 15, 2019
| $btn = $this->find("xpath", $this->newFileFolderButtonXpath); | ||
| if ($btn === null) { | ||
| return false; | ||
| } else { |
skshetry
reviewed
May 15, 2019
| ); | ||
| if (!$button) { | ||
| return false; | ||
| } else { |
dpakach
force-pushed
the
test-issue-35155
branch
2 times, most recently
from
5be814d to
73e39cd
Compare
individual-it
requested changes
May 17, 2019
individual-it
left a comment
individual-it
left a comment
Member
There was a problem hiding this comment.
looks generally good to me, just a small request
work for additional PRs:
- test with single files
- test through API
| And file "lorem.txt" should be listed on the webUI | ||
| And file "lorem (2).txt" should not be listed on the webUI | ||
|
|
||
| Scenario: User tries to upload existing file in public link share with permissions upload-write-without-modify |
Member
There was a problem hiding this comment.
upload-write-without-modify ? copy-paste problem?
individual-it
approved these changes
May 17, 2019
Contributor
Author
|
Backport on #35267 |
This was referenced May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add acceptance test for checking changing sharing permissions from
Related Issue
Motivation and Context
How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: