Skip to content

Acceptance test for giving controlled access to users to change their fullname#35270

Merged
individual-it merged 1 commit into
owncloud:masterfrom
bhawanaprasain:configfile
May 22, 2019
Merged

Acceptance test for giving controlled access to users to change their fullname#35270
individual-it merged 1 commit into
owncloud:masterfrom
bhawanaprasain:configfile

Conversation

@bhawanaprasain

@bhawanaprasain bhawanaprasain commented May 20, 2019

Copy link
Copy Markdown
Contributor

Description

Administrator can give controlled access to users in settings page to change their full name

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@individual-it

individual-it commented May 21, 2019

Copy link
Copy Markdown
Member

@bhawanaprasain please make a backport to stable10 branch

@skshetry skshetry changed the title Acceptance test for giving controlled access to users to change thei… Acceptance test for giving controlled access to users to change their fullname May 21, 2019
@bhawanaprasain bhawanaprasain mentioned this pull request May 21, 2019
Merged
10 tasks
paurakhsharma
paurakhsharma reviewed May 21, 2019
View reviewed changes
Comment thread tests/acceptance/features/bootstrap/WebUIPersonalGeneralSettingsContext.php Outdated
"anything", $this->getSession()
);
PHPUnit\Framework\Assert::fail("changing the full name was possible, but should not");
echo "next one\n";

@paurakhsharma paurakhsharma May 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this debug code?
Or it is intended?

paurakhsharma
paurakhsharma reviewed May 21, 2019
View reviewed changes

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhawanaprasain I have some comments. Please check them.

individual-it
individual-it requested changes May 21, 2019
View reviewed changes

@individual-it individual-it left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paurakhsharma good catch

@codecov

codecov Bot commented May 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35270   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a974c...98222ec. Read the comment docs.

@codecov

codecov Bot commented May 21, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #35270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35270   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ead9c...aba1f69. Read the comment docs.

@individual-it individual-it merged commit 64fb41f into owncloud:master May 22, 2019
@individual-it

individual-it commented May 22, 2019

Copy link
Copy Markdown
Member

@bhawanaprasain please backport to stable10 branch

@phil-davis

phil-davis commented May 24, 2019

Copy link
Copy Markdown
Contributor

Backport stable10 #35287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it approved these changes
@dpakach dpakach Awaiting requested review from dpakach
@skshetry skshetry Awaiting requested review from skshetry
+1 more reviewer
@paurakhsharma paurakhsharma paurakhsharma left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@bhawanaprasain bhawanaprasain

Labels

3 - To Review dev:acceptance-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bhawanaprasain @individual-it @phil-davis @paurakhsharma