Skip to content

[stable10] Acceptance test for giving controlled access to users to change their fullname#35287

Merged
individual-it merged 1 commit into
owncloud:stable10from
bhawanaprasain:stable10-configfile
May 24, 2019
Merged

[stable10] Acceptance test for giving controlled access to users to change their fullname#35287
individual-it merged 1 commit into
owncloud:stable10from
bhawanaprasain:stable10-configfile

Conversation

@bhawanaprasain

@bhawanaprasain bhawanaprasain commented May 21, 2019

Copy link
Copy Markdown
Contributor

Backport on #35270

Description

We can share folders with groups having emoji in the group name

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@bhawanaprasain bhawanaprasain changed the title [stable10-configfile] #35270 [stable10-configfile] Acceptance test for giving controlled access to users to change their fullname May 21, 2019
@codecov

codecov Bot commented May 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35287 into stable10 will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           stable10   #35287      +/-   ##
============================================
- Coverage     45.49%   45.07%   -0.42%     
============================================
  Files           116      116              
  Lines         11545    11539       -6     
  Branches       1300     1299       -1     
============================================
- Hits           5252     5201      -51     
- Misses         5909     5957      +48     
+ Partials        384      381       -3
Flag Coverage Δ
#javascript 53.2% <ø> (-0.65%) ⬇️
#phpunit 30.71% <ø> (ø) ⬆️
Impacted Files Coverage Δ
core/js/shareitemmodel.js 67.76% <0%> (-12.24%) ⬇️
core/js/sharedialogshareelistview.js 76.22% <0%> (-4.26%) ⬇️
apps/files_sharing/js/PublicUploadView.js 67.39% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52d3c7...5fe7eee. Read the comment docs.

@codecov

codecov Bot commented May 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35287 into stable10 will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35287      +/-   ##
==============================================
- Coverage       64.91%   64.64%   -0.28%     
  Complexity      20089    20089              
==============================================
  Files            1226     1289      +63     
  Lines           69535    76943    +7408     
  Branches            0     1300    +1300     
==============================================
+ Hits            45142    49738    +4596     
- Misses          24393    26821    +2428     
- Partials            0      384     +384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.78% <ø> (+0.86%) 20089 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.82% <0%> (-9.19%) 74% <0%> (ø)
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3705219...1a41f73. Read the comment docs.

@bhawanaprasain

Copy link
Copy Markdown
Contributor Author

@dpakach @skshetry @paurakhsharma please review my PR.

@bhawanaprasain bhawanaprasain changed the title [stable10-configfile] Acceptance test for giving controlled access to users to change their fullname [stable10] Acceptance test for giving controlled access to users to change their fullname May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants