Skip to content

[10.2.0] Add acceptance test for checking changing sharing permissions#35279

Closed
dpakach wants to merge 1 commit into
release-10.2.0from
stable10-test-issue-35155
Closed

[10.2.0] Add acceptance test for checking changing sharing permissions#35279
dpakach wants to merge 1 commit into
release-10.2.0from
stable10-test-issue-35155

Conversation

@dpakach

@dpakach dpakach commented May 21, 2019

Copy link
Copy Markdown
Contributor

Backport for #35166

@codecov

codecov Bot commented May 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35279 into release-10.2.0 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35279      +/-   ##
====================================================
- Coverage             64.39%   64.39%   -0.01%     
  Complexity            20051    20051              
====================================================
  Files                  1285     1285              
  Lines                 76848    76848              
  Branches               1308     1308              
====================================================
- Hits                  49485    49484       -1     
- Misses                26979    26980       +1     
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <ø> (-0.01%) 20051 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/Wrapper/Encryption.php 67.81% <0%> (-0.25%) 156% <0%> (ø)
lib/private/Server.php 86.54% <0%> (-0.12%) 253% <0%> (ø)
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28bc7ab...ead9ec5. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35279 into release-10.2.0 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35279      +/-   ##
====================================================
- Coverage             64.39%   64.39%   -0.01%     
  Complexity            20051    20051              
====================================================
  Files                  1285     1285              
  Lines                 76848    76848              
  Branches               1308     1308              
====================================================
- Hits                  49485    49484       -1     
- Misses                26979    26980       +1     
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <ø> (-0.01%) 20051 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/Wrapper/Encryption.php 67.81% <0%> (-0.25%) 156% <0%> (ø)
lib/private/Server.php 86.54% <0%> (-0.12%) 253% <0%> (ø)
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28bc7ab...ead9ec5. Read the comment docs.

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we backporting to release-10.2.0 branch?
We do not want to add anything there.
I guess CI for #35262 is the blocker - we need to get that merged so that stable10 is up-to-date.

@dpakach

dpakach commented May 22, 2019

Copy link
Copy Markdown
Contributor Author

@phil-davis I didn't noticed that PR, will make a backport in stable10 now that #35262 has been merged.

@dpakach dpakach closed this May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants