Skip to content

Filessharing with groups that contain emojis in the group-name#35286

Merged
phil-davis merged 1 commit into
owncloud:masterfrom
bhawanaprasain:filessharing
Jun 4, 2019
Merged

Filessharing with groups that contain emojis in the group-name#35286
phil-davis merged 1 commit into
owncloud:masterfrom
bhawanaprasain:filessharing

Conversation

@bhawanaprasain

@bhawanaprasain bhawanaprasain commented May 21, 2019

Copy link
Copy Markdown
Contributor

Description

We can share folders to groups having emoji in the group name.

Part of issue #34437

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@bhawanaprasain

Copy link
Copy Markdown
Contributor Author

@dpakach @skshetry @paurakhsharma please review my PR.

@codecov

codecov Bot commented May 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35286 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35286   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ead9c...649669b. Read the comment docs.

@codecov

codecov Bot commented May 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35286 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35286   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef563f...81467ce. Read the comment docs.

@individual-it individual-it changed the title Filessharing Filessharing with groups that contain emojis in the group-name May 24, 2019

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@individual-it

Copy link
Copy Markdown
Member

@bhawanaprasain please fix the conflicts and ping me

@phil-davis

Copy link
Copy Markdown
Contributor

Backport stable10 #35416

@bhawanaprasain

Copy link
Copy Markdown
Contributor Author

@individual-it I have fixed the conflicts

@phil-davis phil-davis merged commit 66f7b3c into owncloud:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants