Skip to content

[Stable-10] Filessharing with groups that contain emojis in the group-name #35416

Merged
phil-davis merged 1 commit into
owncloud:stable10from
bhawanaprasain:stable10-filessharing
Jun 5, 2019
Merged

[Stable-10] Filessharing with groups that contain emojis in the group-name #35416
phil-davis merged 1 commit into
owncloud:stable10from
bhawanaprasain:stable10-filessharing

Conversation

@bhawanaprasain

Copy link
Copy Markdown
Contributor

Backport of #35286

Description

We can share folders to groups having emoji in the group name.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@bhawanaprasain bhawanaprasain changed the title [Stable-10] Acceptance test for sharing folders with groups having emoji in their… [Stable-10] Filessharing with groups that contain emojis in the group-name Jun 4, 2019
@phil-davis

Copy link
Copy Markdown
Contributor

@bhawanaprasain please rebase so that CI runs again and will pass.

@bhawanaprasain bhawanaprasain force-pushed the stable10-filessharing branch from 4e1216c to 0def520 Compare June 5, 2019 05:29
@codecov

codecov Bot commented Jun 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35416 into stable10 will decrease coverage by 2.56%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35416      +/-   ##
==============================================
- Coverage       67.24%   64.68%   -2.57%     
+ Complexity      20266    20103     -163     
==============================================
  Files            1179     1293     +114     
  Lines           65834    76976   +11142     
  Branches            0     1300    +1300     
==============================================
+ Hits            44272    49793    +5521     
- Misses          21562    26799    +5237     
- Partials            0      384     +384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.83% <ø> (-1.42%) 20103 <ø> (-163)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.91% <0%> (-9.17%) 74% <0%> (ø)
lib/private/Files/Storage/DAV.php 81.09% <0%> (-7.78%) 0% <0%> (-161%)
lib/private/DB/MySQLMigrator.php 57.69% <0%> (-2.31%) 7% <0%> (ø)
...private/DB/MySqlSchemaColumnDefinitionListener.php 5.35% <0%> (-0.42%) 46% <0%> (ø)
apps/files_external/lib/Command/Backends.php 0% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_external/lib/Lib/Backend/DAV.php 0% <0%> (ø) 0% <0%> (?)
core/js/sharedialogexpirationview.js 76.56% <0%> (ø) 0% <0%> (?)
apps/files_external/js/app.js 11.36% <0%> (ø) 0% <0%> (?)
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc01e21...0def520. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35416 into stable10 will decrease coverage by 2.56%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35416      +/-   ##
==============================================
- Coverage       67.24%   64.68%   -2.57%     
+ Complexity      20266    20103     -163     
==============================================
  Files            1179     1293     +114     
  Lines           65834    76976   +11142     
  Branches            0     1300    +1300     
==============================================
+ Hits            44272    49793    +5521     
- Misses          21562    26799    +5237     
- Partials            0      384     +384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.83% <ø> (-1.42%) 20103 <ø> (-163)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.91% <0%> (-9.17%) 74% <0%> (ø)
lib/private/Files/Storage/DAV.php 81.09% <0%> (-7.78%) 0% <0%> (-161%)
lib/private/DB/MySQLMigrator.php 57.69% <0%> (-2.31%) 7% <0%> (ø)
...private/DB/MySqlSchemaColumnDefinitionListener.php 5.35% <0%> (-0.42%) 46% <0%> (ø)
apps/files_external/lib/Command/Backends.php 0% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_external/lib/Lib/Backend/DAV.php 0% <0%> (ø) 0% <0%> (?)
core/js/sharedialogexpirationview.js 76.56% <0%> (ø) 0% <0%> (?)
apps/files_external/js/app.js 11.36% <0%> (ø) 0% <0%> (?)
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc01e21...0def520. Read the comment docs.

@phil-davis phil-davis merged commit 8fab61e into owncloud:stable10 Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants