get rid of "the share fields of the last share should include" step#35295
Conversation
0aa8891 to
3c03b23
Compare
Codecov Report
@@ Coverage Diff @@
## master #35295 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35295 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
| And user "user0" has shared folder "/folder1" with user "user1" with permissions 31 | ||
| And user "user1" has shared folder "/folder1/folder2" with user "user2" with permissions 31 | ||
| When user "user1" moves folder "/folder1/folder2" to "/moved-out/folder2" using the WebDAV API | ||
| Then the share fields of the last share should include |
There was a problem hiding this comment.
this actually used to be 🐍 🛢️ as the share fields of the last share should include would not check the current status but the status saved when creating the share
this was added in #35204 but causes problems when an invalid request is done but the original `lastShareData` need to be accessed e.g `\Sharing::getMimeTypeOfLastSharedFile`
3c03b23 to
95a758c
Compare
dpakach
left a comment
There was a problem hiding this comment.
Looks Good. Lets keep decreasing our code base 😄 !
|
backport in #35298 |
Description
lastShareDataneed to be accessed e.g in\Sharing::getMimeTypeOfLastSharedFile()Then the share fields of the last share should include.If we done the share creation request directly before the check we should use we use
Then the fields of the last response should include.If there are some steps in between the share creation and the check, we anyway should query the current state of the share by
When user "..." gets the info of the last share using the sharing API, otherwise we only check the saved data and not the current state of the shareMotivation and Context
fixing CI in various apps that were broken by #35204
Types of changes
Checklist:
Open tasks: