Skip to content

get rid of "the share fields of the last share should include" step#35295

Merged
individual-it merged 2 commits into
masterfrom
getRidOfShareFields
May 22, 2019
Merged

get rid of "the share fields of the last share should include" step#35295
individual-it merged 2 commits into
masterfrom
getRidOfShareFields

Conversation

@individual-it

@individual-it individual-it commented May 22, 2019

Copy link
Copy Markdown
Member

Description

  1. saving the response of the share data after update was added in API acceptance tests for public link share permissions #35204 but causes problems when an invalid request was done but the original lastShareData need to be accessed e.g in \Sharing::getMimeTypeOfLastSharedFile()
  2. completely get rid of Then the share fields of the last share should include.
    If we done the share creation request directly before the check we should use we use Then the fields of the last response should include.
    If there are some steps in between the share creation and the check, we anyway should query the current state of the share by When user "..." gets the info of the last share using the sharing API, otherwise we only check the saved data and not the current state of the share

Motivation and Context

fixing CI in various apps that were broken by #35204

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it individual-it self-assigned this May 22, 2019
@individual-it
individual-it force-pushed the getRidOfShareFields branch from 0aa8891 to 3c03b23 Compare May 22, 2019 08:14
@codecov

codecov Bot commented May 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35295   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ead9c...3c03b23. Read the comment docs.

@codecov

codecov Bot commented May 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35295   +/-   ##
=========================================
  Coverage     65.54%   65.54%           
  Complexity    18647    18647           
=========================================
  Files          1218     1218           
  Lines         70546    70546           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23933    23933           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.9% <ø> (ø) 18647 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ead9c...95a758c. Read the comment docs.

And user "user0" has shared folder "/folder1" with user "user1" with permissions 31
And user "user1" has shared folder "/folder1/folder2" with user "user2" with permissions 31
When user "user1" moves folder "/folder1/folder2" to "/moved-out/folder2" using the WebDAV API
Then the share fields of the last share should include

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually used to be 🐍 🛢️ as the share fields of the last share should include would not check the current status but the status saved when creating the share

this was added in #35204 but causes problems when an invalid request is done but the original `lastShareData` need to be accessed e.g `\Sharing::getMimeTypeOfLastSharedFile`

@dpakach dpakach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Lets keep decreasing our code base 😄 !

@individual-it

Copy link
Copy Markdown
Member Author

backport in #35298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants