[stable10] get rid of "the share fields of the last share should include" step#35298
Merged
Conversation
this was added in #35204 but causes problems when an invalid request is done but the original `lastShareData` need to be accessed e.g `\Sharing::getMimeTypeOfLastSharedFile`
11 tasks
Member
Author
|
CI failed with |
dpakach
approved these changes
May 22, 2019
Codecov Report
@@ Coverage Diff @@
## stable10 #35298 +/- ##
===========================================
Coverage 64.64% 64.64%
Complexity 20089 20089
===========================================
Files 1289 1289
Lines 76943 76943
Branches 1300 1300
===========================================
Hits 49738 49738
Misses 26821 26821
Partials 384 384
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35298 +/- ##
===========================================
Coverage 64.64% 64.64%
Complexity 20089 20089
===========================================
Files 1289 1289
Lines 76943 76943
Branches 1300 1300
===========================================
Hits 49738 49738
Misses 26821 26821
Partials 384 384
Continue to review full report at Codecov.
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #35295