Acceptance test for creating password with emoji#35315
Merged
Merged
Conversation
Contributor
Author
|
@dpakach @paurakhsharma @skshetry please review on my PR . |
Codecov Report
@@ Coverage Diff @@
## master #35315 +/- ##
=========================================
Coverage 65.54% 65.54%
Complexity 18647 18647
=========================================
Files 1218 1218
Lines 70546 70546
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23933 23933
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35315 +/- ##
=========================================
Coverage 65.53% 65.53%
Complexity 18648 18648
=========================================
Files 1218 1218
Lines 70549 70549
Branches 1288 1288
=========================================
Hits 46236 46236
Misses 23936 23936
Partials 377 377
Continue to review full report at Codecov.
|
5 tasks
bhawanaprasain
force-pushed
the
passwordwithemoji
branch
from
May 24, 2019 08:58
e1fbc09 to
5607d77
Compare
bhawanaprasain
force-pushed
the
passwordwithemoji
branch
from
May 28, 2019 08:27
5607d77 to
8773df0
Compare
phil-davis
approved these changes
Jun 4, 2019
Contributor
|
@bhawanaprasain please backport to |
This was referenced Jun 5, 2019
Contributor
|
Backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Users can create their password including emojis.
Part of issue #34437
Types of changes