Skip to content

[stable10] Acceptance test for creating password with emoji#35431

Merged
phil-davis merged 2 commits into
stable10from
stable10-emojipassword
Jun 5, 2019
Merged

[stable10] Acceptance test for creating password with emoji#35431
phil-davis merged 2 commits into
stable10from
stable10-emojipassword

Conversation

@individual-it

Copy link
Copy Markdown
Member

backport of #35315 and #35430

@codecov

codecov Bot commented Jun 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35431 into stable10 will decrease coverage by 2.56%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35431      +/-   ##
==============================================
- Coverage       67.24%   64.68%   -2.57%     
+ Complexity      20266    20103     -163     
==============================================
  Files            1179     1293     +114     
  Lines           65834    76976   +11142     
  Branches            0     1300    +1300     
==============================================
+ Hits            44272    49793    +5521     
- Misses          21562    26799    +5237     
- Partials            0      384     +384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.83% <ø> (-1.42%) 20103 <ø> (-163)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.91% <0%> (-9.17%) 74% <0%> (ø)
lib/private/Files/Storage/DAV.php 81.09% <0%> (-7.78%) 0% <0%> (-161%)
lib/private/DB/MySQLMigrator.php 57.69% <0%> (-2.31%) 7% <0%> (ø)
...private/DB/MySqlSchemaColumnDefinitionListener.php 5.35% <0%> (-0.42%) 46% <0%> (ø)
apps/files_external/lib/Command/Backends.php 0% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_external/lib/Lib/Backend/DAV.php 0% <0%> (ø) 0% <0%> (?)
core/js/sharedialogexpirationview.js 76.56% <0%> (ø) 0% <0%> (?)
apps/files_external/js/app.js 11.36% <0%> (ø) 0% <0%> (?)
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc01e21...1f11044. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35431 into stable10 will decrease coverage by 2.56%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35431      +/-   ##
==============================================
- Coverage       67.24%   64.68%   -2.57%     
+ Complexity      20266    20103     -163     
==============================================
  Files            1179     1293     +114     
  Lines           65834    76976   +11142     
  Branches            0     1300    +1300     
==============================================
+ Hits            44272    49793    +5521     
- Misses          21562    26799    +5237     
- Partials            0      384     +384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.83% <ø> (-1.42%) 20103 <ø> (-163)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.91% <0%> (-9.17%) 74% <0%> (ø)
lib/private/Files/Storage/DAV.php 81.09% <0%> (-7.78%) 0% <0%> (-161%)
lib/private/DB/MySQLMigrator.php 57.69% <0%> (-2.31%) 7% <0%> (ø)
...private/DB/MySqlSchemaColumnDefinitionListener.php 5.35% <0%> (-0.42%) 46% <0%> (ø)
apps/files_external/lib/Command/Backends.php 0% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_external/lib/Lib/Backend/DAV.php 0% <0%> (ø) 0% <0%> (?)
core/js/sharedialogexpirationview.js 76.56% <0%> (ø) 0% <0%> (?)
apps/files_external/js/app.js 11.36% <0%> (ø) 0% <0%> (?)
... and 152 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc01e21...1f11044. Read the comment docs.

@phil-davis
phil-davis merged commit e5f6ef7 into stable10 Jun 5, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the stable10-emojipassword branch June 5, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants