Skip to content

Web UI sharing internal users use no skeleton step#35358

Merged
skshetry merged 1 commit into
masterfrom
webUISharingInterUsers-use-no-skeleton-step
May 31, 2019
Merged

Web UI sharing internal users use no skeleton step#35358
skshetry merged 1 commit into
masterfrom
webUISharingInterUsers-use-no-skeleton-step

Conversation

@paurakhsharma

Copy link
Copy Markdown
Contributor

Description

Decrease CI run time for webUISharingInternalUsers suite

Many tests don't require files/folder still, the skeleton files are copied
using user "<user-name>" has been created with default attributes and without skeleton files
we now don't copy skeleton files for those users.

Related Issue

owncloud/QA#621

Motivation and Context

  • Make CI faster in scenarios where there is no need for user files.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@paurakhsharma paurakhsharma changed the title Web ui sharing inter users use no skeleton step Web UI sharing internal users use no skeleton step May 29, 2019
@paurakhsharma
paurakhsharma force-pushed the webUISharingInterUsers-use-no-skeleton-step branch from faabb47 to d107c84 Compare May 30, 2019 06:37
@codecov

codecov Bot commented May 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35358   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1309e1c...d107c84. Read the comment docs.

@codecov

codecov Bot commented May 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35358   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0c93d...09f0178. Read the comment docs.

@paurakhsharma
paurakhsharma force-pushed the webUISharingInterUsers-use-no-skeleton-step branch 2 times, most recently from 4092a4f to 5c391b6 Compare May 30, 2019 11:33
@paurakhsharma
paurakhsharma requested review from dpakach and skshetry May 30, 2019 11:34
@paurakhsharma paurakhsharma self-assigned this May 30, 2019
@paurakhsharma
paurakhsharma marked this pull request as ready for review May 30, 2019 11:35
@paurakhsharma
paurakhsharma force-pushed the webUISharingInterUsers-use-no-skeleton-step branch 2 times, most recently from ac45933 to b2d9b6a Compare May 30, 2019 17:24

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how much difference it makes to the speed, when creating a user with skeleton files?
(there are 3 commands to get the current skeleton files setting, clear the setting, then put back the setting - they all have to run each time, so maybe they take quite a lot of time anyway?)

Comment thread tests/acceptance/features/webUISharingInternalUsers/shareAutocompletion.feature Outdated
@paurakhsharma

Copy link
Copy Markdown
Contributor Author

Do you know how much difference it makes to the speed when creating a user with skeleton files?

We have seen a significant improvement in this scenario.
CI time has reduced from about 1hrs to 40mins.

@paurakhsharma
paurakhsharma force-pushed the webUISharingInterUsers-use-no-skeleton-step branch from b2d9b6a to 09f0178 Compare May 31, 2019 06:31
@skshetry
skshetry merged commit 5579390 into master May 31, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the webUISharingInterUsers-use-no-skeleton-step branch May 31, 2019 07:44
@paurakhsharma

Copy link
Copy Markdown
Contributor Author

Backport on: #35391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants