Skip to content

[stable10] web ui sharing inter users use no skeleton step#35391

Merged
phil-davis merged 1 commit into
stable10from
stable10-webUISharingInterUsers-use-no-skeleton-step
Jun 3, 2019
Merged

[stable10] web ui sharing inter users use no skeleton step#35391
phil-davis merged 1 commit into
stable10from
stable10-webUISharingInterUsers-use-no-skeleton-step

Conversation

@paurakhsharma

Copy link
Copy Markdown
Contributor

Backport of: #35358

@codecov

codecov Bot commented Jun 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35391 into stable10 will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35391      +/-   ##
==============================================
- Coverage        65.8%   64.69%   -1.12%     
- Complexity      20100    20123      +23     
==============================================
  Files            1227     1293      +66     
  Lines           69594    77057    +7463     
  Branches            0     1300    +1300     
==============================================
+ Hits            45799    49854    +4055     
- Misses          23795    26819    +3024     
- Partials            0      384     +384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.84% <ø> (+0.03%) 20123 <ø> (+23) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtags.js 90% <0%> (ø) 0% <0%> (?)
.../public/Files/ObjectStore/ObjectStoreException.php 0% <0%> (ø) 1% <0%> (?)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5522a...211cb9d. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35391 into stable10 will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35391      +/-   ##
==============================================
- Coverage        65.8%   64.69%   -1.12%     
- Complexity      20100    20123      +23     
==============================================
  Files            1227     1293      +66     
  Lines           69594    77057    +7463     
  Branches            0     1300    +1300     
==============================================
+ Hits            45799    49854    +4055     
- Misses          23795    26819    +3024     
- Partials            0      384     +384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.84% <ø> (+0.03%) 20123 <ø> (+23) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtags.js 90% <0%> (ø) 0% <0%> (?)
.../public/Files/ObjectStore/ObjectStoreException.php 0% <0%> (ø) 1% <0%> (?)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5522a...211cb9d. Read the comment docs.

@phil-davis
phil-davis merged commit 2b0ead6 into stable10 Jun 3, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the stable10-webUISharingInterUsers-use-no-skeleton-step branch June 3, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants