Send requests in loop rather than scenario outline to speed up CI#35395
Merged
Conversation
Contributor
Author
|
@dpakach @paurakhsharma @skshetry please review on my PR. |
Codecov Report
@@ Coverage Diff @@
## master #35395 +/- ##
=========================================
Coverage 65.63% 65.63%
Complexity 18666 18666
=========================================
Files 1221 1221
Lines 70595 70595
Branches 1288 1288
=========================================
Hits 46335 46335
Misses 23883 23883
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35395 +/- ##
=========================================
Coverage 65.66% 65.66%
Complexity 18666 18666
=========================================
Files 1221 1221
Lines 70597 70597
Branches 1288 1288
=========================================
Hits 46358 46358
Misses 23862 23862
Partials 377 377
Continue to review full report at Codecov.
|
dpakach
changed the title
dpakach
reviewed
Jun 3, 2019
bhawanaprasain
force-pushed
the
runtimeminimizer
branch
2 times, most recently
from
June 4, 2019 10:33
3d83ea7 to
ec34ed3
Compare
Contributor
Author
|
@dpakach @paurakhsharma @skshetry please review again. |
bhawanaprasain
force-pushed
the
runtimeminimizer
branch
from
June 5, 2019 05:25
ec34ed3 to
09f15f3
Compare
individual-it
requested changes
Jun 5, 2019
bhawanaprasain
force-pushed
the
runtimeminimizer
branch
2 times, most recently
from
June 5, 2019 06:14
dc795c8 to
5c079c7
Compare
phil-davis
reviewed
Jun 5, 2019
phil-davis
left a comment
phil-davis
left a comment
Contributor
There was a problem hiding this comment.
Try to make the text of each step have consistent words.
bhawanaprasain
force-pushed
the
runtimeminimizer
branch
from
June 5, 2019 08:50
5c079c7 to
3595daf
Compare
phil-davis
reviewed
Jun 6, 2019
phil-davis
left a comment
phil-davis
left a comment
Contributor
There was a problem hiding this comment.
2 comments remaining now.
Contributor
|
@bhawanaprasain because of core CI trouble overnight, you will need to rebase to latest master as well as fixing up the review comments. |
bhawanaprasain
force-pushed
the
runtimeminimizer
branch
from
June 6, 2019 08:30
3595daf to
043618c
Compare
bhawanaprasain
force-pushed
the
runtimeminimizer
branch
from
June 6, 2019 08:50
043618c to
bcfa9b4
Compare
individual-it
approved these changes
Jun 10, 2019
Member
|
@bhawanaprasain please backport to stable10 |
6 tasks
Contributor
|
Backport |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These tests speedup CI .
Checklist: