Add batch user creation step for speeding up the requests by dpakach · Pull Request #35403 · owncloud/core

dpakach · 2019-06-03T05:48:40Z

Description

Add new step for user creation using batch requests to speed up the ci

Related Issue

Related issue speed-up CI QA#621

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Backport (if applicable set "backport-request" label and remove when the backport was done)

skshetry · 2019-06-03T06:52:07Z

Can you make this run by default? Would be good to find what difference does this make.

codecov · 2019-06-03T08:19:26Z

Codecov Report

Merging #35403 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #35403   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	`53.69% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`67.04% <ø> (ø)`	`18666 <ø> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666e084...2aa2d37. Read the comment docs.

codecov · 2019-06-03T08:19:29Z

Codecov Report

Merging #35403 into master will decrease coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #35403      +/-   ##
============================================
- Coverage     65.93%   65.61%   -0.33%     
  Complexity    18735    18735              
============================================
  Files          1160     1221      +61     
  Lines         63470    70793    +7323     
  Branches          0     1288    +1288     
============================================
+ Hits          41852    46449    +4597     
- Misses        21618    23967    +2349     
- Partials          0      377     +377

Flag	Coverage Δ	Complexity Δ
#javascript	`53.69% <ø> (?)`	`0 <ø> (?)`
#phpunit	`66.97% <ø> (+1.03%)`	`18735 <ø> (ø)`	⬇️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/DB/PostgreSqlMigrator.php	`0% <0%> (-100%)`	`6% <0%> (ø)`
...ilder/ExpressionBuilder/PgSqlExpressionBuilder.php	`0% <0%> (-88.89%)`	`3% <0%> (ø)`
lib/private/DB/AdapterPgSql.php	`0% <0%> (-85.72%)`	`2% <0%> (ø)`
lib/private/Files/Storage/DAV.php	`80.46% <0%> (-9.1%)`	`0% <0%> (ø)`
lib/private/DB/Migrator.php	`53.01% <0%> (-2.41%)`	`30% <0%> (ø)`
lib/private/legacy/db.php	`70.51% <0%> (-1.29%)`	`33% <0%> (ø)`
lib/private/legacy/util.php	`67.17% <0%> (-1.03%)`	`240% <0%> (ø)`
apps/dav/lib/CardDAV/CardDavBackend.php	`83.05% <0%> (-0.24%)`	`86% <0%> (ø)`
apps/dav/lib/CalDAV/CalDavBackend.php	`80.52% <0%> (-0.14%)`	`179% <0%> (ø)`
lib/private/DB/MDB2SchemaManager.php	`87.71% <0%> (ø)`	`17% <0%> (ø)`	⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8d8e9...e024d4d. Read the comment docs.

individual-it

please squash before merging

phil-davis · 2019-06-12T14:30:20Z

There are various acceptance test CI fails, so I guess something in this code is not quite right.

skshetry · 2019-06-13T12:53:15Z

+		$requests,
+		$client = null
+	) {
+		if (!isset($client)) {


Only null check should be enough. isset checks if the variable is declared or not in addition to null-check.

Suggested change

if (!isset($client)) {

if ($client === null) {

or,

Suggested change

if (!isset($client)) {

if (is_null($client)) {

skshetry · 2019-06-13T13:07:41Z

+			);
+		}
+		// Send all the requests in parallel.
+		$response = HttpRequestHelper::sendBatchRequest($requests, $client);


This is not really a response. Could get confusing.

dpakach · 2019-06-13T16:08:00Z

Backport on #35522

phil-davis · 2019-06-13T16:13:56Z

@dpakach tomorrow please talk with @skshetry about his recent comments. Then if there is good refactoring to do, make another PR for that.

dpakach · 2019-06-13T16:21:55Z

@dpakach tomorrow please talk with @skshetry about his recent comments. Then if there is good refactoring to do, make another PR for that.

@phil-davis I have already started refactoring. It's almost over. I couldnt do PR today because it was late.

dpakach added 3 - To Review dev:acceptance-tests QA:team labels Jun 3, 2019

dpakach requested review from paurakhsharma and skshetry June 3, 2019 05:48

dpakach self-assigned this Jun 3, 2019

dpakach added the backport-request label Jun 3, 2019

dpakach force-pushed the batch-request branch from 6b7f846 to 2aa2d37 Compare June 3, 2019 08:19

dpakach requested review from individual-it and phil-davis June 3, 2019 11:36

dpakach force-pushed the batch-request branch 2 times, most recently from 299635b to 8c9b8f6 Compare June 4, 2019 02:41

dpakach changed the title ~~Add batch user creation step for speeding up the requests~~ [wip]Add batch user creation step for speeding up the requests Jun 4, 2019

dpakach force-pushed the batch-request branch from 8c9b8f6 to 85e4559 Compare June 11, 2019 07:00

dpakach changed the title ~~[wip]Add batch user creation step for speeding up the requests~~ Add batch user creation step for speeding up the requests Jun 11, 2019

dpakach force-pushed the batch-request branch from 85e4559 to d1c68bd Compare June 11, 2019 09:24

phil-davis reviewed Jun 12, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/Provisioning.php Outdated

Comment thread tests/TestHelpers/HttpRequestHelper.php Outdated

Comment thread tests/acceptance/features/bootstrap/Provisioning.php

Comment thread tests/acceptance/features/bootstrap/Provisioning.php Outdated

paurakhsharma reviewed Jun 12, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/Provisioning.php

individual-it approved these changes Jun 12, 2019

View reviewed changes

phil-davis approved these changes Jun 12, 2019

View reviewed changes

dpakach requested review from individual-it, paurakhsharma and phil-davis June 13, 2019 08:07

individual-it approved these changes Jun 13, 2019

View reviewed changes

phil-davis approved these changes Jun 13, 2019

View reviewed changes

Add batch user creation step for speeding up the requests

e024d4d

dpakach force-pushed the batch-request branch from cf6b2cd to e024d4d Compare June 13, 2019 09:20

phil-davis added 4 - To release and removed 3 - To Review labels Jun 13, 2019

skshetry reviewed Jun 13, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/Provisioning.php

skshetry reviewed Jun 13, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/Provisioning.php

DeepDiver1975 merged commit 917e035 into master Jun 13, 2019

delete-merged-branch Bot deleted the batch-request branch June 13, 2019 15:15

dpakach mentioned this pull request Jun 13, 2019

[Stable10]Add batch user creation step for speeding up the requests #35522

Merged

dpakach removed the backport-request label Jun 13, 2019

dpakach mentioned this pull request Jun 14, 2019

Create multiple users in single steps in acceptance test feature files #35525

Merged

11 tasks

dpakach mentioned this pull request Jun 26, 2019

Add Better error handling to batch user create function in acceptance tests #35672

Merged

11 tasks

Uh oh!

Conversation

dpakach commented Jun 3, 2019

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

Uh oh!

skshetry commented Jun 3, 2019

Uh oh!

codecov Bot commented Jun 3, 2019

Codecov Report

Uh oh!

codecov Bot commented Jun 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

individual-it left a comment

Choose a reason for hiding this comment

Uh oh!

phil-davis commented Jun 12, 2019

Uh oh!

skshetry Jun 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

skshetry Jun 13, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dpakach commented Jun 13, 2019

Uh oh!

phil-davis commented Jun 13, 2019

Uh oh!

dpakach commented Jun 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Jun 3, 2019 •

edited

Loading

skshetry Jun 13, 2019 •

edited

Loading