Skip to content

Create multiple users in single steps in acceptance test feature files#35525

Merged
DeepDiver1975 merged 1 commit into
masterfrom
fix-create-user-multiple
Jun 14, 2019
Merged

Create multiple users in single steps in acceptance test feature files#35525
DeepDiver1975 merged 1 commit into
masterfrom
fix-create-user-multiple

Conversation

@dpakach

@dpakach dpakach commented Jun 14, 2019

Copy link
Copy Markdown
Contributor

Description

In Acceptance tests replace steps

And user "user0" has been created with default attributes and skeleton files
And user "user1" has been created with default attributes and skeleton files

By

 And these users have been created with default attributes and skeleton files:
      | username |
      | user0    |
      | user1    |

Related Issue

Motivation and Context

#35403 Added creating multiple users concurrently with batch requests. This PR uses these steps to make the tests faster

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@phil-davis

Copy link
Copy Markdown
Contributor

Backport stable10 #35532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants