Get rid of setting configs via WebUISharingContext#35422
Merged
Conversation
We already set the capabilities via FeatureContext on both fed and local servers. The same settings were run twice causing conflicts, causing some of the enabled configs to get disabled. The settings are already tracked.
paurakhsharma
left a comment
paurakhsharma
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me 👍
Contributor
Author
|
Backport for |
phil-davis
approved these changes
Jun 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #35422 +/- ##
=========================================
Coverage 65.66% 65.66%
Complexity 18666 18666
=========================================
Files 1221 1221
Lines 70597 70597
Branches 1288 1288
=========================================
Hits 46358 46358
Misses 23862 23862
Partials 377 377
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #35422 +/- ##
=========================================
Coverage 65.66% 65.66%
Complexity 18666 18666
=========================================
Files 1221 1221
Lines 70597 70597
Branches 1288 1288
=========================================
Hits 46358 46358
Misses 23862 23862
Partials 377 377
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already set the capabilities via FeatureContext on both fed and local servers.
The same settings were run twice causing conflicts, causing some of the enabled
configs to get disabled. The settings are already tracked (on Sharing.php), so they were redundant.
Motivation and Context
Fed sharing on remote server was getting disabled after running the tests. Took too much time to pin this down.
How Has This Been Tested?
Previously, the last output would show fed_sharing disabled. Now, it should not be disabled.
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: