[stable10] Get rid of setting configs via WebUISharingContext#35423
Merged
Conversation
skshetry
requested review from
dpakach,
individual-it,
paurakhsharma and
phil-davis
11 tasks
phil-davis
approved these changes
Jun 4, 2019
phil-davis
force-pushed
the
stable10-remove-setup-sharingconfig
branch
from
7b1a0f7 to
4ec7557
Compare
Contributor
|
rebased to get good CI |
Codecov Report
@@ Coverage Diff @@
## stable10 #35423 +/- ##
===============================================
+ Coverage 45.49% 64.41% +18.92%
- Complexity 0 20103 +20103
===============================================
Files 116 1293 +1177
Lines 11545 76976 +65431
Branches 1300 1300
===============================================
+ Hits 5252 49586 +44334
- Misses 5909 27006 +21097
Partials 384 384
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #35423 +/- ##
===========================================
Coverage 64.68% 64.68%
Complexity 20103 20103
===========================================
Files 1293 1293
Lines 76976 76976
Branches 1300 1300
===========================================
Hits 49793 49793
Misses 26799 26799
Partials 384 384
Continue to review full report at Codecov.
|
Contributor
|
dumb drone CI error https://drone.owncloud.com/owncloud/core/18010/346 |
We already set the capabilities via FeatureContext on both fed and local servers. The same settings were run twice causing conflicts, causing some of the enabled configs to get disabled. The settings are already tracked.
phil-davis
force-pushed
the
stable10-remove-setup-sharingconfig
branch
from
4ec7557 to
dc77b5e
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport for #35422