Skip to content

Make create user steps specify explicitly that the user has skeleton files#35438

Merged
phil-davis merged 2 commits into
masterfrom
and-skeleton-files
Jun 6, 2019
Merged

Make create user steps specify explicitly that the user has skeleton files#35438
phil-davis merged 2 commits into
masterfrom
and-skeleton-files

Conversation

@phil-davis

@phil-davis phil-davis commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

Description

As part of "speedup CI" we are sorting out which acceptance test scenarios run with users that have a full skeleton, and which are fine to run without a full set of skeleton files. (the skeleton files take some time to get created at every user creation, specially the webUI skeleton)

So we want to be more specific in the user creation steps to say if the user is getting skeleton files or not.

This PR adds extra step text forms for:

Given /^user "([^"]*)" has been created with default attributes$/
Given /^these users have been created\s?(with default attributes|)\s?(but not initialized|):$/

so that they explicitly say that the user gets skeleton files:

Given /^user "([^"]*)" has been created with default attributes and skeleton files$/
Given /^these users have been created\s?(with default attributes and skeleton files|)\s?(but not initialized|):$/

For now, the old shorter step text forms are being retained, because many apps use these. After making this refactoring in the apps, we can then go back and remove the old shorter step text forms.

Related Issue

owncloud/QA#621

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport stable10 #35439

@codecov

codecov Bot commented Jun 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35438   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760d0ce...1d66d63. Read the comment docs.

@codecov

codecov Bot commented Jun 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35438   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18666    18666           
=========================================
  Files          1221     1221           
  Lines         70597    70597           
  Branches       1288     1288           
=========================================
  Hits          46358    46358           
  Misses        23862    23862           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.04% <ø> (ø) 18666 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ade7f63...5fff759. Read the comment docs.

@phil-davis
phil-davis force-pushed the and-skeleton-files branch from 1d66d63 to d6d9bb1 Compare June 5, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants