Make create user steps specify explicitly that the user has skeleton files#35438
Merged
Conversation
individual-it
approved these changes
Jun 5, 2019
Contributor
Author
|
Backport |
Codecov Report
@@ Coverage Diff @@
## master #35438 +/- ##
=========================================
Coverage 65.66% 65.66%
Complexity 18666 18666
=========================================
Files 1221 1221
Lines 70597 70597
Branches 1288 1288
=========================================
Hits 46358 46358
Misses 23862 23862
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35438 +/- ##
=========================================
Coverage 65.66% 65.66%
Complexity 18666 18666
=========================================
Files 1221 1221
Lines 70597 70597
Branches 1288 1288
=========================================
Hits 46358 46358
Misses 23862 23862
Partials 377 377
Continue to review full report at Codecov.
|
phil-davis
force-pushed
the
and-skeleton-files
branch
from
June 5, 2019 16:48
1d66d63 to
d6d9bb1
Compare
phil-davis
force-pushed
the
and-skeleton-files
branch
from
June 6, 2019 04:31
d6d9bb1 to
5fff759
Compare
This was referenced Jun 7, 2019
This was referenced Jun 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of "speedup CI" we are sorting out which acceptance test scenarios run with users that have a full skeleton, and which are fine to run without a full set of skeleton files. (the skeleton files take some time to get created at every user creation, specially the webUI skeleton)
So we want to be more specific in the user creation steps to say if the user is getting skeleton files or not.
This PR adds extra step text forms for:
so that they explicitly say that the user gets skeleton files:
For now, the old shorter step text forms are being retained, because many apps use these. After making this refactoring in the apps, we can then go back and remove the old shorter step text forms.
Related Issue
owncloud/QA#621
How Has This Been Tested?
CI
Types of changes
Checklist:
Open tasks: