Skip to content

Remove deprecated default attributes test steps#35451

Merged
phil-davis merged 2 commits into
masterfrom
remove-default-attributes-steps
Jun 7, 2019
Merged

Remove deprecated default attributes test steps#35451
phil-davis merged 2 commits into
masterfrom
remove-default-attributes-steps

Conversation

@phil-davis

@phil-davis phil-davis commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

Description

This is a follow-on PR from #35438 - it removes the "old" create user steps that did not explicitly specify that skeleton files are used.

App acceptance tests are being adjusted to use the new "and skeleton files" step forms.

Related Issue

owncloud/QA#621

Motivation and Context

Make all create user acceptance test steps explicitly say if the skeleton is to be used.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented Jun 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35451 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35451      +/-   ##
============================================
+ Coverage     65.66%   65.68%   +0.01%     
- Complexity    18666    18730      +64     
============================================
  Files          1221     1221              
  Lines         70597    70780     +183     
  Branches       1288     1288              
============================================
+ Hits          46358    46492     +134     
- Misses        23862    23911      +49     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.05% <ø> (+0.01%) 18730 <ø> (+64) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/DAV/Sharing/Plugin.php 68.29% <0%> (-3.14%) 14% <0%> (+9%)
apps/dav/lib/CalDAV/CalendarObject.php 94.11% <0%> (-2.44%) 18% <0%> (ø)
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php 83.33% <0%> (-1.67%) 14% <0%> (ø)
lib/private/Files/Node/File.php 95.71% <0%> (-1.21%) 32% <0%> (ø)
lib/private/Archive/TAR.php 86.33% <0%> (-0.9%) 66% <0%> (+10%)
apps/dav/lib/CardDAV/Plugin.php 15% <0%> (-0.79%) 8% <0%> (ø)
apps/dav/lib/CalDAV/Calendar.php 85.47% <0%> (-0.25%) 48% <0%> (+7%)
lib/private/Memcache/ArrayCache.php 100% <0%> (ø) 19% <0%> (+3%) ⬆️
lib/private/Console/Application.php 0% <0%> (ø) 23% <0%> (ø) ⬇️
apps/dav/lib/CalDAV/CalendarHome.php 0% <0%> (ø) 19% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9285c...57a0839. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35451 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35451      +/-   ##
============================================
+ Coverage     65.66%   65.68%   +0.01%     
- Complexity    18666    18730      +64     
============================================
  Files          1221     1221              
  Lines         70597    70780     +183     
  Branches       1288     1288              
============================================
+ Hits          46358    46492     +134     
- Misses        23862    23911      +49     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.05% <ø> (+0.01%) 18730 <ø> (+64) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/DAV/Sharing/Plugin.php 68.29% <0%> (-3.14%) 14% <0%> (+9%)
apps/dav/lib/CalDAV/CalendarObject.php 94.11% <0%> (-2.44%) 18% <0%> (ø)
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php 83.33% <0%> (-1.67%) 14% <0%> (ø)
lib/private/Files/Node/File.php 95.71% <0%> (-1.21%) 32% <0%> (ø)
lib/private/Archive/TAR.php 86.33% <0%> (-0.9%) 66% <0%> (+10%)
apps/dav/lib/CardDAV/Plugin.php 15% <0%> (-0.79%) 8% <0%> (ø)
apps/dav/lib/CalDAV/Calendar.php 85.47% <0%> (-0.25%) 48% <0%> (+7%)
lib/private/Memcache/ArrayCache.php 100% <0%> (ø) 19% <0%> (+3%) ⬆️
lib/private/Console/Application.php 0% <0%> (ø) 23% <0%> (ø) ⬇️
apps/dav/lib/CalDAV/CalendarHome.php 0% <0%> (ø) 19% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9285c...57a0839. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor Author

Random annoying drone fail. I restarted drone.

@phil-davis
phil-davis merged commit 9a2b6c1 into master Jun 7, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the remove-default-attributes-steps branch June 7, 2019 08:04
@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport stable10 #35452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants