Revert "Convert shareWith to lower case"#35448
Merged
sharidas merged 3 commits intoJun 7, 2019
Merged
Conversation
sharidas
approved these changes
Jun 7, 2019
Contributor
|
Also needs adjustment of related acceptance test(s), because they no longer pass. |
Codecov Report
@@ Coverage Diff @@
## master #35448 +/- ##
============================================
+ Coverage 65.66% 65.68% +0.01%
- Complexity 18666 18728 +62
============================================
Files 1221 1221
Lines 70597 70778 +181
Branches 1288 1288
============================================
+ Hits 46358 46490 +132
- Misses 23862 23911 +49
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35448 +/- ##
============================================
+ Coverage 65.66% 65.67% +0.01%
- Complexity 18666 18728 +62
============================================
Files 1221 1221
Lines 70597 70778 +181
Branches 1288 1288
============================================
+ Hits 46358 46486 +128
- Misses 23862 23915 +53
Partials 377 377
Continue to review full report at Codecov.
|
Contributor
|
I pushed 2 acceptance test commits:
|
delete-merged-branch
Bot
deleted the
revert-35084-convert-share-with-tolowercase-inshare-api
branch
June 7, 2019 07:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #35084
Revert of
stable10can be found in PR #35449