Skip to content

Revert "Convert shareWith to lower case"#35448

Merged
sharidas merged 3 commits into
masterfrom
revert-35084-convert-share-with-tolowercase-inshare-api
Jun 7, 2019
Merged

Revert "Convert shareWith to lower case"#35448
sharidas merged 3 commits into
masterfrom
revert-35084-convert-share-with-tolowercase-inshare-api

Conversation

@micbar

@micbar micbar commented Jun 6, 2019

Copy link
Copy Markdown
Contributor

Reverts #35084

Revert of stable10 can be found in PR #35449

@micbar micbar added this to the development milestone Jun 6, 2019
@micbar
micbar requested a review from sharidas June 6, 2019 18:26
@micbar micbar self-assigned this Jun 6, 2019
@micbar micbar added p2-high Escalation, on top of current planning, release blocker regression labels Jun 6, 2019
@phil-davis

Copy link
Copy Markdown
Contributor

Also needs adjustment of related acceptance test(s), because they no longer pass.
I will look...

@phil-davis phil-davis self-assigned this Jun 7, 2019
@codecov

codecov Bot commented Jun 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35448 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35448      +/-   ##
============================================
+ Coverage     65.66%   65.68%   +0.01%     
- Complexity    18666    18728      +62     
============================================
  Files          1221     1221              
  Lines         70597    70778     +181     
  Branches       1288     1288              
============================================
+ Hits          46358    46490     +132     
- Misses        23862    23911      +49     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.05% <ø> (+0.01%) 18728 <ø> (+62) ⬆️
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.23% <ø> (-0.05%) 202 <0> (-2)
apps/dav/lib/DAV/Sharing/Plugin.php 68.29% <0%> (-3.14%) 14% <0%> (+9%)
apps/dav/lib/CalDAV/CalendarObject.php 94.11% <0%> (-2.44%) 18% <0%> (ø)
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php 83.33% <0%> (-1.67%) 14% <0%> (ø)
lib/private/Files/Node/File.php 95.71% <0%> (-1.21%) 32% <0%> (ø)
lib/private/Archive/TAR.php 86.33% <0%> (-0.9%) 66% <0%> (+10%)
apps/dav/lib/CardDAV/Plugin.php 15% <0%> (-0.79%) 8% <0%> (ø)
apps/dav/lib/CalDAV/Calendar.php 85.47% <0%> (-0.25%) 48% <0%> (+7%)
lib/private/Memcache/ArrayCache.php 100% <0%> (ø) 19% <0%> (+3%) ⬆️
lib/private/Console/Application.php 0% <0%> (ø) 23% <0%> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9285c...17b4a5a. Read the comment docs.

@codecov

codecov Bot commented Jun 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35448 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35448      +/-   ##
============================================
+ Coverage     65.66%   65.67%   +0.01%     
- Complexity    18666    18728      +62     
============================================
  Files          1221     1221              
  Lines         70597    70778     +181     
  Branches       1288     1288              
============================================
+ Hits          46358    46486     +128     
- Misses        23862    23915      +53     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.05% <ø> (+0.01%) 18728 <ø> (+62) ⬆️
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.23% <ø> (-0.05%) 202 <0> (-2)
apps/dav/lib/DAV/Sharing/Plugin.php 68.29% <0%> (-3.14%) 14% <0%> (+9%)
apps/dav/lib/CalDAV/CalendarObject.php 94.11% <0%> (-2.44%) 18% <0%> (ø)
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php 83.33% <0%> (-1.67%) 14% <0%> (ø)
lib/private/Files/Node/File.php 95.71% <0%> (-1.21%) 32% <0%> (ø)
lib/private/Archive/TAR.php 86.33% <0%> (-0.9%) 66% <0%> (+10%)
apps/dav/lib/CardDAV/Plugin.php 15% <0%> (-0.79%) 8% <0%> (ø)
lib/private/DB/Connection.php 66.91% <0%> (-0.74%) 49% <0%> (ø)
lib/private/Files/View.php 84.3% <0%> (-0.31%) 398% <0%> (ø)
apps/dav/lib/CalDAV/Calendar.php 85.47% <0%> (-0.25%) 48% <0%> (+7%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9285c...17b4a5a. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor

I pushed 2 acceptance test commits:

  • "API share_with user response is now case sensitive" - after reverting this code, when somebody uses the sharing API to share with another user and they specify the user name (UID) in mixed or upper case, then the share_with field in the success response has the user name in the mixed or upper case.
  • "Issue 35382 is resolved - webUI sharing to uppercase username works" - after reverting this code, issue File is not shared with user whose username contains capital letter #35382 is fixed, so the test scenario is adjusted to expect the correct successful behaviour.

@sharidas
sharidas merged commit cf07b32 into master Jun 7, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the revert-35084-convert-share-with-tolowercase-inshare-api branch June 7, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - To Review p2-high Escalation, on top of current planning, release blocker regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants