Skip to content

Revert "[stable10] Backport of Convert shareWith to lower case"#35449

Merged
sharidas merged 3 commits into
stable10from
revert-35138-convert-share-with-tolowercase-inshare-api-stable10
Jun 7, 2019
Merged

Revert "[stable10] Backport of Convert shareWith to lower case"#35449
sharidas merged 3 commits into
stable10from
revert-35138-convert-share-with-tolowercase-inshare-api-stable10

Conversation

@micbar

@micbar micbar commented Jun 6, 2019

Copy link
Copy Markdown
Contributor

Reverts #35138

Revert for master is in PR #35448

Repairs issue #35382

@micbar micbar added 3 - To Review regression p2-high Escalation, on top of current planning, release blocker labels Jun 6, 2019
@micbar micbar added this to the development milestone Jun 6, 2019
@micbar
micbar requested a review from sharidas June 6, 2019 18:28
@micbar micbar self-assigned this Jun 6, 2019
@codecov

codecov Bot commented Jun 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35449 into stable10 will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35449      +/-   ##
==============================================
- Coverage       64.69%   64.42%   -0.27%     
- Complexity      20103    20161      +58     
==============================================
  Files            1293     1293              
  Lines           76977    77116     +139     
  Branches         1300     1300              
==============================================
- Hits            49797    49680     -117     
- Misses          26796    27052     +256     
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.54% <ø> (-0.3%) 20161 <ø> (+58)
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.25% <ø> (-0.05%) 202 <0> (-2)
apps/files_external/lib/Lib/Storage/SMB.php 0% <0%> (-47.95%) 0% <0%> (ø)
apps/dav/lib/CalDAV/CalendarObject.php 94.11% <0%> (-2.66%) 18% <0%> (ø)
apps/dav/lib/DAV/Sharing/Plugin.php 68.29% <0%> (-0.94%) 14% <0%> (ø)
lib/private/Archive/TAR.php 86.33% <0%> (-0.9%) 66% <0%> (+10%)
apps/dav/lib/CardDAV/AddressBook.php 76.19% <0%> (-0.6%) 21% <0%> (ø)
apps/dav/lib/CalDAV/Calendar.php 85.47% <0%> (-0.38%) 48% <0%> (+4%)
lib/private/Memcache/ArrayCache.php 100% <0%> (ø) 19% <0%> (+2%) ⬆️
lib/private/Console/Application.php 0% <0%> (ø) 23% <0%> (+4%) ⬆️
apps/dav/lib/CalDAV/CalendarHome.php 0% <0%> (ø) 19% <0%> (+12%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619572c...d6e723b. Read the comment docs.

@codecov

codecov Bot commented Jun 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35449 into stable10 will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35449      +/-   ##
==============================================
+ Coverage       64.69%   64.71%   +0.01%     
- Complexity      20103    20161      +58     
==============================================
  Files            1293     1293              
  Lines           76977    77116     +139     
  Branches         1300     1300              
==============================================
+ Hits            49797    49902     +105     
- Misses          26796    26830      +34     
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (+0.01%) 20161 <ø> (+58) ⬆️
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.25% <ø> (-0.05%) 202 <0> (-2)
apps/dav/lib/CalDAV/CalendarObject.php 94.11% <0%> (-2.66%) 18% <0%> (ø)
apps/dav/lib/DAV/Sharing/Plugin.php 68.29% <0%> (-0.94%) 14% <0%> (ø)
lib/private/Archive/TAR.php 86.33% <0%> (-0.9%) 66% <0%> (+10%)
apps/dav/lib/CardDAV/AddressBook.php 76.19% <0%> (-0.6%) 21% <0%> (ø)
apps/dav/lib/CalDAV/Calendar.php 85.47% <0%> (-0.38%) 48% <0%> (+4%)
lib/private/Memcache/ArrayCache.php 100% <0%> (ø) 19% <0%> (+2%) ⬆️
lib/private/Console/Application.php 0% <0%> (ø) 23% <0%> (+4%) ⬆️
apps/dav/lib/CalDAV/CalendarHome.php 0% <0%> (ø) 19% <0%> (+12%) ⬆️
lib/private/Files/Cache/Cache.php 97.61% <0%> (ø) 110% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619572c...d6e723b. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor

I pushed 2 acceptance test commits. See description in comment #35448 (comment)

@sharidas
sharidas merged commit 782df3b into stable10 Jun 7, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the revert-35138-convert-share-with-tolowercase-inshare-api-stable10 branch June 7, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - To Review p2-high Escalation, on top of current planning, release blocker regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants