Skip to content

Remove deprecated default attributes test steps #35451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phil-davis merged 2 commits into from
Jun 7, 2019
Merged

Remove deprecated default attributes test steps #35451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b6c917
Remove deprecated default attributes test steps
phil-davis Jun 7, 2019
57a0839
Adjust more 'with skeleton files' steps
phil-davis Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions tests/acceptance/features/bootstrap/Provisioning.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@ public function userHasBeenCreatedOnDatabaseBackend($user) {
}

/**
* @Given /^user "([^"]*)" has been created with default attributes$/
* @Given /^user "([^"]*)" has been created with default attributes and skeleton files$/
*
* @param string $user
Expand Down Expand Up @@ -331,21 +330,7 @@ public function theseUsersHaveBeenCreatedWithoutSkeletonFiles(TableNode $table)
}

/**
* @Given these users have been created with skeleton files:
* expects a table of users with the heading
* "|username|password|displayname|email|"
* password, displayname & email are optional
*
* @param TableNode $table
*
* @return void
*/
public function theseUsersHaveBeenCreatedWithSkeletonFiles(TableNode $table) {
$this->theseUsersHaveBeenCreated("", "", $table);
}

/**
* @Given /^these users have been created\s?(with default attributes|with default attributes and skeleton files|)\s?(but not initialized|):$/
* @Given /^these users have been created with ?(default attributes and|) skeleton files ?(but not initialized|):$/
* expects a table of users with the heading
* "|username|password|displayname|email|"
* password, displayname & email are optional
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/webUISharingAutocompletion/shareAutocompletion.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ Feature: Autocompletion of share-with names
Given the administrator has set the minimum characters for sharing autocomplete to "4"
And user "regularuser" has logged in using the webUI
And the user has browsed to the files page
And these users have been created but not initialized:
And these users have been created with skeleton files but not initialized:
| username | password | displayname | email |
| use | %alt1% | Use | uz@oc.com.np |
And the user has opened the share dialog for folder "simple-folder"
Expand Down
6 changes: 3 additions & 3 deletions tests/acceptance/features/webUISharingExternal/federationSharing.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ Feature: Federation Sharing - sharing with users on other cloud storages

Scenario: test sharing folder to a remote server and resharing it back to the local
Given using server "LOCAL"
And these users have been created:
And these users have been created with skeleton files:
| username |
| user2 |
When the user shares folder "simple-folder" with remote user "user1@%remote_server_without_scheme%" using the webUI
Expand All @@ -261,7 +261,7 @@ Feature: Federation Sharing - sharing with users on other cloud storages

Scenario: test resharing folder as readonly and set it as readonly by resharer
Given using server "LOCAL"
And these users have been created:
And these users have been created with skeleton files:
| username |
| user2 |
When the user shares folder "simple-folder" with remote user "user1@%remote_server_without_scheme%" using the webUI
Expand All @@ -279,7 +279,7 @@ Feature: Federation Sharing - sharing with users on other cloud storages

Scenario: test resharing folder and set it as readonly by owner
Given using server "LOCAL"
And these users have been created:
And these users have been created with skeleton files:
| username |
| user2 |
When the user shares folder "simple-folder" with remote user "user1@%remote_server_without_scheme%" using the webUI
Expand Down