Skip to content

[stable10] Acceptance test whitespace#35456

Merged
phil-davis merged 2 commits into
stable10from
acceptance-test-whitespace
Jun 7, 2019
Merged

[stable10] Acceptance test whitespace#35456
phil-davis merged 2 commits into
stable10from
acceptance-test-whitespace

Conversation

@phil-davis

@phil-davis phil-davis commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

Description

  • fixup a couple of very minor whitespace diffs between master and stable10
  • add a comment on the cliEncryption suite like is already on the other bundled ecryption suites in stable10. This makes it really obvious when doing diffs between stable10 and master why cliEncryption suite is in stable10 but not in master
git diff -D stable10..master tests/acceptance/

is actually very small, which is good.

Motivation and Context

Keep test code as similar as possible between master and stable10

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov

codecov Bot commented Jun 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35456 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35456   +/-   ##
===========================================
  Coverage        64.8%    64.8%           
  Complexity      20176    20176           
===========================================
  Files            1293     1293           
  Lines           77155    77155           
  Branches         1300     1300           
===========================================
  Hits            49997    49997           
  Misses          26774    26774           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.95% <ø> (ø) 20176 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ce20b...a992334. Read the comment docs.

2 similar comments
@codecov

codecov Bot commented Jun 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35456 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35456   +/-   ##
===========================================
  Coverage        64.8%    64.8%           
  Complexity      20176    20176           
===========================================
  Files            1293     1293           
  Lines           77155    77155           
  Branches         1300     1300           
===========================================
  Hits            49997    49997           
  Misses          26774    26774           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.95% <ø> (ø) 20176 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ce20b...a992334. Read the comment docs.

@codecov

codecov Bot commented Jun 7, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35456 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35456   +/-   ##
===========================================
  Coverage        64.8%    64.8%           
  Complexity      20176    20176           
===========================================
  Files            1293     1293           
  Lines           77155    77155           
  Branches         1300     1300           
===========================================
  Hits            49997    49997           
  Misses          26774    26774           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.95% <ø> (ø) 20176 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ce20b...a992334. Read the comment docs.

@phil-davis phil-davis merged commit 90d65f2 into stable10 Jun 7, 2019
@delete-merged-branch delete-merged-branch Bot deleted the acceptance-test-whitespace branch June 7, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants