Acceptance tests for release 10.2.1 by phil-davis · Pull Request #35562 · owncloud/core

phil-davis · 2019-06-17T16:44:30Z

Description

Backport all acceptance test changes to release-10.2.1
Then we will be running the most acceptance tests that we have, including various new test scenarios that have been added in the 2 months since release-10.2.0 was branched off from stable10

I could have tried to identify which acceptance test changes are additions of useful tests/test code fixes vs refactoring. And then just cherry-pick those that are additions of useful tests/test code fixes. But then many of those cherry-picks would have to be adjusted back to the way of doing things before the various refactorings. So it is much easier to cherry-pick everything. That way we get the acceptance test suite as it is currently working in stable10

How Has This Been Tested?

CI

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

The `getWebDriverSession` is not part of the `Mink\Driver\DriverInterface`, but is provided by the `Selenium2Driver`. So, as Sauce uses selenium grid, this will only be used when Sauce environment variables are set (other drivers do not have this).

…autocomplete list in webUI

…ups suites

…c suite

… and deleteTags

phil-davis · 2019-06-17T16:48:09Z

Acceptance test PRs in stable10 that have their commits in here:
#35008
#35090
#35120
#35141
#35152
#35158
#35173
#35186
#35190
#35216
#35217
#35200
#35231
#35250
#35251
#35259
#35281
#35296
#35297
#35298
#35299
#35276
#35285
#35302
#35306 - Accessing sharetab directly for a long list of files - has js code changes and acceptance test changes - this one is a minor fix as well as acceptance test code. It has been reverted from this PR (see last commit of the PR)
#35291
#35320
#35300
#35287
#35333
#35343
#35351
#35352
#35357
#35360
#35361
#35369
#35370
#35372
#35374
#35376
#35377
#35379
#35381
#35367
#35383
#35391
#35402
#35393
#35404
#35424
#35410
#35411
#35425
#35428
#35423
#35416
#35431
#35409
#35435
#35439
#35449 - Revert "[stable10] Backport of Convert shareWith to lower case" - 1st commit was already there, I cherry-picked the other 2 commits
#35452
#35456
#35462
#35465
#35463
#35467
#35469
#35470
#35473
#35479
#35481
#35489
#35495
#35496
#35497
#35504
#35529
#35397 - [stable10] use a multi line approach to display share autocomplete - has lots of acceptance test refactoring in it - took the middle 6 commits related to UI tests, those have useful acceptance test code refactoring
and then added 281af08e47 "Adjust SharingDialog suffixToIdentify Groups Users RemoteUsers" so that the test expectations match the old strings
#35514
#35515
#35517
#35522
#35527
#35532
#35533
#35536
#35537
#35547
#35548
#35553
#35559
#35560

…ic links

… Link section

…exposed by ocs api on share

this was added in #35204 but causes problems when an invalid request is done but the original `lastShareData` need to be accessed e.g `\Sharing::getMimeTypeOfLastSharedFile`

…ns' steps

…le share

individual-it

if CI passes it must be good!

phil-davis · 2019-06-18T03:47:48Z

I luv CI (not) https://drone.owncloud.com/owncloud/core/18468/754

  [Composer\Downloader\TransportException]                                                                                                                                     
The "https://packagist.org/p/provider-latest%249a01b3c3c1cd2ae4764e239f6e1d56d32c44b05e77ce9132e81f2777d9d30e0e.json" file could not be downloaded (HTTP/1.1 404 Not Found)

Restarting drone build...

phil-davis · 2019-06-18T04:59:33Z

CI is good. That is very nice. It means that all the latest acceptance test scenarios pass against 10.2.1 code.
@patrickjahns please review.

micbar · 2019-06-18T09:14:56Z

@phil-davis Could you remove #35306 from this PR and create a separate backport?

phil-davis · 2019-06-18T10:00:20Z

I pushed a revert of #35306 on the end:

git revert 86066adb1e879c2670f674bba3b10c91f05032e6

Removing the commit from the middle was causing annoying conflicts in later commits.

patrickjahns

LGTM

… list of files" This reverts commit 86066ad.

phil-davis · 2019-06-18T12:06:20Z

@patrickjahns this is ready to merge - you are the person controlling release-10.2.0 branch.

skshetry and others added 11 commits June 17, 2019 20:31

change method shareWithUserOrGroup from private to public

4e69f9a

createUser function changed from private to public

dff29a0

restore system config after running acceptance test

2eca355

shareAutocompletion feature updated for the user to be not listed in …

d0a28ed

…autocomplete list in webUI

Test Helper to read file from server

b268df6

Split ocs Auth acceptance tests into apiAuthOcs suite

d12e0a8

Split apiProvisioning acceptance groups tests into apiProvisioningGro…

31765c8

…ups suites

Split apiShareManagement acceptance tests into apiShareManagementBasi…

e638e27

…c suite

Split apiWebdavLocks acceptance tests into apiWebdavLocks2 suite

2f8489b

reorganization or createTags feature file into createTags, removeTags…

45bbef2

… and deleteTags

phil-davis added 2 - Developing dev:acceptance-tests QA:team labels Jun 17, 2019

phil-davis self-assigned this Jun 17, 2019

bhawanaprasain and others added 14 commits June 18, 2019 06:54

Acceptance test for renaming subfolders with same name shared by publ…

07aeae6

…ic links

Add issue tag on scenario with invalid status code

ce5354c

feature test for share autocomplete list in webUI

8732776

tests demonstating issue #35200

eb107f7

Acceptance test for renaming folders with different path in Shared By…

c565eaf

… Link section

Acceptance test for renaming folders with different path in Shared By…

ee452d6

… Link section

quote inline code when checking response

357cbe1

Add api acceptance test for checking that the sensitive data are not …

8145dbc

…exposed by ocs api on share

restore acceptance tests to the correct server

197ea57

Add exception page page object and its related steps in acceptance test

5cebc6e

Add WebUI acceptance tests for checking permissions on public link share

314af42

API acceptance tests for public link share permissions

39cbb80

revert saving response data in lastShareData when updating share

d46a60c

this was added in #35204 but causes problems when an invalid request is done but the original `lastShareData` need to be accessed e.g `\Sharing::getMimeTypeOfLastSharedFile`

replace checking last share response with just checking last response

7022643

bhawanaprasain and others added 9 commits June 18, 2019 06:54

API test for sharing files when receiver has matching files

12e0822

Add test steps for upload download of files in public share

2963dc0

Enhance reShare acceptance test scenarios

b62b7f1

fix diff between master and stable10 in Auth tests

a87739c

webUISharingExternal use no skeleton

afc918b

Refactor reShare.feature to use the 'shares file with, with permissio…

b32e87a

…ns' steps

Adjust tests for issue 33733 that now pass

1b32ceb

Add test scenarios for requesting combinations of permissions on a fi…

45d2b3b

…le share

test app version after app was updated to new patch version

ff78380

phil-davis force-pushed the accceptance-tests-for-release-10-2-1 branch from fa9b3a4 to ff78380 Compare June 18, 2019 01:12

phil-davis added 3 - To Review and removed 2 - Developing labels Jun 18, 2019

phil-davis requested review from individual-it and patrickjahns June 18, 2019 01:38

phil-davis marked this pull request as ready for review June 18, 2019 01:40

individual-it approved these changes Jun 18, 2019

View reviewed changes

phil-davis mentioned this pull request Jun 18, 2019

[release-10.2.1] Return "password fields" only if public-link password is set. #35541 #35563

Merged

10 tasks

phil-davis requested a review from micbar June 18, 2019 07:14

phil-davis mentioned this pull request Jun 18, 2019

[10.2.1] Backport to Fix response when user is removed from group #35570

Merged

11 tasks

patrickjahns approved these changes Jun 18, 2019

View reviewed changes

Revert "[stable10] Backport of Accessing sharetab directly for a long…

b71b326

… list of files" This reverts commit 86066ad.

phil-davis force-pushed the accceptance-tests-for-release-10-2-1 branch from 22def8d to b71b326 Compare June 18, 2019 10:55

micbar merged commit cf1a31a into release-10.2.1 Jun 18, 2019

delete-merged-branch Bot deleted the accceptance-tests-for-release-10-2-1 branch June 18, 2019 12:08

patrickjahns added this to the QA milestone Jun 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Acceptance tests for release 10.2.1#35562

Acceptance tests for release 10.2.1#35562
micbar merged 131 commits into
release-10.2.1from
accceptance-tests-for-release-10-2-1

phil-davis commented Jun 17, 2019 •

edited

Loading

Uh oh!

phil-davis commented Jun 17, 2019 •

edited

Loading

Uh oh!

individual-it left a comment

Uh oh!

phil-davis commented Jun 18, 2019

Uh oh!

phil-davis commented Jun 18, 2019

Uh oh!

micbar commented Jun 18, 2019

Uh oh!

phil-davis commented Jun 18, 2019 •

edited

Loading

Uh oh!

patrickjahns left a comment

Uh oh!

phil-davis commented Jun 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

phil-davis commented Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

phil-davis commented Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

individual-it left a comment

Choose a reason for hiding this comment

Uh oh!

phil-davis commented Jun 18, 2019

Uh oh!

phil-davis commented Jun 18, 2019

Uh oh!

micbar commented Jun 18, 2019

Uh oh!

phil-davis commented Jun 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrickjahns left a comment

Choose a reason for hiding this comment

Uh oh!

phil-davis commented Jun 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

phil-davis commented Jun 17, 2019 •

edited

Loading

phil-davis commented Jun 17, 2019 •

edited

Loading

phil-davis commented Jun 18, 2019 •

edited

Loading